Author: mduerig
Date: Tue Jul 26 14:30:33 2016
New Revision: 1754134
URL: http://svn.apache.org/viewvc?rev=1754134&view=rev
Log:
OAK-4277: Finalise de-duplication caches
Tests for WriteCacheManager
Added:
jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/WriteCacheManagerTest.java
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/WriterCacheManager.java
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/WriterCacheManager.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/WriterCacheManager.java?rev=1754134&r1=1754133&r2=1754134&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/WriterCacheManager.java
(original)
+++
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/WriterCacheManager.java
Tue Jul 26 14:30:33 2016
@@ -41,7 +41,6 @@ import org.apache.jackrabbit.oak.api.jmx
// FIXME OAK-4277: Finalise de-duplication caches
// implement configuration, monitoring and management
-// add unit tests
// document
public abstract class WriterCacheManager {
private static final int DEFAULT_STRING_CACHE_SIZE = getInteger(
Added:
jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/WriteCacheManagerTest.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/WriteCacheManagerTest.java?rev=1754134&view=auto
==============================================================================
---
jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/WriteCacheManagerTest.java
(added)
+++
jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/WriteCacheManagerTest.java
Tue Jul 26 14:30:33 2016
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.jackrabbit.oak.segment;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertTrue;
+
+import com.google.common.base.Supplier;
+import org.apache.jackrabbit.oak.segment.WriterCacheManager.Default;
+import org.apache.jackrabbit.oak.segment.WriterCacheManager.Empty;
+import org.junit.Test;
+
+public class WriteCacheManagerTest {
+
+ @Test
+ public void emptyGenerations() {
+ WriterCacheManager cache = Empty.INSTANCE;
+ assertEquals(cache.getTemplateCache(0), cache.getTemplateCache(1));
+ assertEquals(cache.getNodeCache(0), cache.getNodeCache(1));
+ assertEquals(cache.getStringCache(0), cache.getStringCache(1));
+ }
+
+ @Test
+ public void nonEmptyGenerations() {
+ WriterCacheManager cache = new Default();
+ assertNotEquals(cache.getTemplateCache(0), cache.getTemplateCache(1));
+ assertNotEquals(cache.getNodeCache(0), cache.getNodeCache(1));
+ assertNotEquals(cache.getStringCache(0), cache.getStringCache(1));
+ }
+
+ @Test
+ public void factory() {
+ WriterCacheManager cache = new Default(new
Supplier<RecordCache<String>>() {
+ int accessCount = 2;
+ @Override
+ public RecordCache<String> get() {
+ assertTrue("Factory should only be invoked once per
generation", --accessCount >= 0);
+ return RecordCache.<String>factory(42).get();
+ }
+ }, RecordCache.<Template>factory(42), NodeCache.factory(42, 2));
+
+ cache.getStringCache(0);
+ cache.getStringCache(0);
+ cache.getStringCache(1);
+ cache.getStringCache(1);
+ cache.getStringCache(1);
+ cache.getStringCache(0);
+ }
+}
