Author: mduerig
Date: Wed Dec 14 13:19:27 2016
New Revision: 1774218
URL: http://svn.apache.org/viewvc?rev=1774218&view=rev
Log:
OAK-5293: Static code analysis and code cleanup
Replace indexed for loop with foreach where possible
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/Template.java
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/Template.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/Template.java?rev=1774218&r1=1774217&r2=1774218&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/Template.java
(original)
+++
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/Template.java
Wed Dec 14 13:19:27 2016
@@ -325,8 +325,8 @@ public class Template {
builder.append(mixinTypes);
builder.append(", ");
}
- for (int i = 0; i < properties.length; i++) {
- builder.append(properties[i]);
+ for (PropertyTemplate property : properties) {
+ builder.append(property);
builder.append(" = ?, ");
}
if (childName == ZERO_CHILD_NODES) {
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java?rev=1774218&r1=1774217&r2=1774218&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java
(original)
+++
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/TarWriter.java
Wed Dec 14 13:19:27 2016
@@ -620,8 +620,8 @@ class TarWriter implements Closeable {
// Compute checksum
int checksum = 0;
- for (int i = 0; i < header.length; i++) {
- checksum += header[i] & 0xff;
+ for (byte aHeader : header) {
+ checksum += aHeader & 0xff;
}
System.arraycopy(
String.format("%06o\0 ", checksum).getBytes(UTF_8), 0,
