Author: mduerig
Date: Wed Dec 14 13:21:19 2016
New Revision: 1774238
URL: http://svn.apache.org/viewvc?rev=1774238&view=rev
Log:
OAK-5293: Static code analysis and code cleanup
Add private constructors to utility classes
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/CacheWeights.java
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/osgi/DeprecationMessage.java
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/codec/Messages.java
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/server/FileStoreUtil.java
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/tool/Utils.java
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/CacheWeights.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/CacheWeights.java?rev=1774238&r1=1774237&r2=1774238&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/CacheWeights.java
(original)
+++
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/CacheWeights.java
Wed Dec 14 13:21:19 2016
@@ -50,6 +50,8 @@ public class CacheWeights {
*/
private static final int SEGMENT_CACHE_OVERHEAD = 32;
+ private CacheWeights() {}
+
public static class OneWeigher<K, V> implements Weigher<K, V> {
@Override
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/osgi/DeprecationMessage.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/osgi/DeprecationMessage.java?rev=1774238&r1=1774237&r2=1774238&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/osgi/DeprecationMessage.java
(original)
+++
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/osgi/DeprecationMessage.java
Wed Dec 14 13:21:19 2016
@@ -26,6 +26,8 @@ class DeprecationMessage {
" functionality but you need to rename your configuration to
target the\n" +
" new component using the PID %s.\n";
+ private DeprecationMessage() {}
+
static String movedPid(String oldPid, String newPid) {
return String.format(MOVED_PID_FORMAT, oldPid, newPid);
}
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/codec/Messages.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/codec/Messages.java?rev=1774238&r1=1774237&r2=1774238&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/codec/Messages.java
(original)
+++
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/codec/Messages.java
Wed Dec 14 13:21:19 2016
@@ -41,6 +41,8 @@ class Messages {
private static final String SEPARATOR = ":";
+ private Messages() {}
+
private static String newRequest(String clientId, String body, boolean
delimited) {
StringBuilder builder = new StringBuilder(MAGIC);
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/server/FileStoreUtil.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/server/FileStoreUtil.java?rev=1774238&r1=1774237&r2=1774238&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/server/FileStoreUtil.java
(original)
+++
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/server/FileStoreUtil.java
Wed Dec 14 13:21:19 2016
@@ -29,7 +29,7 @@ class FileStoreUtil {
private static final Logger log =
LoggerFactory.getLogger(FileStoreUtil.class);
- FileStoreUtil() {
+ private FileStoreUtil() {
// Prevent instantiation
}
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/tool/Utils.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/tool/Utils.java?rev=1774238&r1=1774237&r2=1774238&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/tool/Utils.java
(original)
+++
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/tool/Utils.java
Wed Dec 14 13:21:19 2016
@@ -37,6 +37,8 @@ class Utils {
private static final int TAR_SEGMENT_CACHE_SIZE =
Integer.getInteger("cache", 256);
+ private Utils() {}
+
static ReadOnlyFileStore openReadOnlyFileStore(File path, BlobStore
blobStore) throws IOException, InvalidFileStoreVersionException {
return fileStoreBuilder(isValidFileStoreOrFail(path))
.withSegmentCacheSize(TAR_SEGMENT_CACHE_SIZE)
