Author: mreutegg
Date: Tue Oct 10 15:11:32 2017
New Revision: 1811709
URL: http://svn.apache.org/viewvc?rev=1811709&view=rev
Log:
OAK-6218: Including id in DocumentStoreException which wrap MongoException
Add affected IDs to exception message and enable test
Modified:
jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStoreException.java
jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java
jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDBExceptionTest.java
Modified:
jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStoreException.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStoreException.java?rev=1811709&r1=1811708&r2=1811709&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStoreException.java
(original)
+++
jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentStoreException.java
Tue Oct 10 15:11:32 2017
@@ -16,6 +16,8 @@
*/
package org.apache.jackrabbit.oak.plugins.document;
+import com.google.common.collect.Lists;
+
/**
* <code>DocumentStoreException</code> is a runtime exception for
* {@code DocumentStore} implementations to signal unexpected problems like
@@ -48,4 +50,10 @@ public class DocumentStoreException exte
return new DocumentStoreException(msg, t);
}
}
+
+ public static DocumentStoreException convert(Throwable t,
+ Iterable<String> ids) {
+ String msg = t.getMessage() + " " + Lists.newArrayList(ids);
+ return convert(t, msg);
+ }
}
Modified:
jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java?rev=1811709&r1=1811708&r2=1811709&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java
(original)
+++
jackrabbit/oak/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentStore.java
Tue Oct 10 15:11:32 2017
@@ -1748,7 +1748,7 @@ public class MongoDocumentStore implemen
invalidateCache(collection, id);
}
}
- return DocumentStoreException.convert(ex);
+ return DocumentStoreException.convert(ex, ids);
}
private <T extends Document> DocumentStoreException
handleException(Exception ex,
Modified:
jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDBExceptionTest.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDBExceptionTest.java?rev=1811709&r1=1811708&r2=1811709&view=diff
==============================================================================
---
jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDBExceptionTest.java
(original)
+++
jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDBExceptionTest.java
Tue Oct 10 15:11:32 2017
@@ -32,14 +32,12 @@ import org.apache.jackrabbit.oak.plugins
import org.apache.jackrabbit.oak.plugins.document.UpdateOp;
import org.apache.jackrabbit.oak.plugins.document.util.Utils;
import org.junit.Before;
-import org.junit.Ignore;
import org.junit.Test;
import static java.util.Collections.singletonList;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
-@Ignore
public class MongoDBExceptionTest {
private MongoDocumentStore store;