Author: mreutegg
Date: Thu Feb 22 08:52:17 2018
New Revision: 1825035
URL: http://svn.apache.org/viewvc?rev=1825035&view=rev
Log:
OAK-6392: Partial lastRev update with branches disabled
Merge revision 1799861 from trunk and enable test
Modified:
jackrabbit/oak/branches/1.6/oak-core/ (props changed)
jackrabbit/oak/branches/1.6/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java
jackrabbit/oak/branches/1.6/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DisableBranchesTest.java
Propchange: jackrabbit/oak/branches/1.6/oak-core/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Feb 22 08:52:17 2018
@@ -1,5 +1,5 @@
/jackrabbit/oak/branches/1.0/oak-core:1665962
/jackrabbit/oak/trunk/oak-blob-plugins:1819950
-/jackrabbit/oak/trunk/oak-core:1781068,1781075,1781248,1781386,1781846,1781907,1782000,1782029,1782196,1782447,1782476,1782770,1782945,1782966,1782973,1782990,1783061,1783066,1783089,1783104-1783105,1783110,1783619,1783720,1783731,1783733,1783738,1783742,1783773,1783855,1783891,1784023,1784034,1784130,1784162,1784251,1784401,1784551,1784574,1784689,1785095,1785108,1785283,1785838,1785917,1785919,1785946,1786122,1787074,1787145,1787151,1787217,1787425,1788056,1788378,1788387-1788389,1788463,1788476,1788850,1789056,1789441,1789534,1790382,1792049,1792463,1792742,1792746,1793013,1793088,1793618,1793627,1793644,1794393,1794417,1794683,1795138,1795314,1795330,1795475,1795488,1795491,1795502,1795594,1795613,1795618,1796144,1796230,1796239,1796274,1796278,1796988,1797378,1798035,1798834,1799219,1799389,1799393,1799924,1800269,1800606,1800613,1800974,1801011,1801013,1801118-1801119,1801675,1802260,1802262,1802286,1802548,1802934,1802938,1802973,1803026,1803247-1803249,1803951,1803953-180395
5,1805851-1805852,1806668,1807308,1807688,1808125,1808128,1808142,1808240,1808246,1809024,1809026,1809131,1809163,1809253,1809255-1809256,1811380,1811952,1811963,1811986,1814332,1818645,1821325,1821358,1821516
+/jackrabbit/oak/trunk/oak-core:1781068,1781075,1781248,1781386,1781846,1781907,1782000,1782029,1782196,1782447,1782476,1782770,1782945,1782966,1782973,1782990,1783061,1783066,1783089,1783104-1783105,1783110,1783619,1783720,1783731,1783733,1783738,1783742,1783773,1783855,1783891,1784023,1784034,1784130,1784162,1784251,1784401,1784551,1784574,1784689,1785095,1785108,1785283,1785838,1785917,1785919,1785946,1786122,1787074,1787145,1787151,1787217,1787425,1788056,1788378,1788387-1788389,1788463,1788476,1788850,1789056,1789441,1789534,1790382,1792049,1792463,1792742,1792746,1793013,1793088,1793618,1793627,1793644,1794393,1794417,1794683,1795138,1795314,1795330,1795475,1795488,1795491,1795502,1795594,1795613,1795618,1796144,1796230,1796239,1796274,1796278,1796988,1797378,1798035,1798834,1799219,1799389,1799393,1799861,1799924,1800269,1800606,1800613,1800974,1801011,1801013,1801118-1801119,1801675,1802260,1802262,1802286,1802548,1802934,1802938,1802973,1803026,1803247-1803249,1803951,180395
3-1803955,1805851-1805852,1806668,1807308,1807688,1808125,1808128,1808142,1808240,1808246,1809024,1809026,1809131,1809163,1809253,1809255-1809256,1811380,1811952,1811963,1811986,1814332,1818645,1821325,1821358,1821516
/jackrabbit/oak/trunk/oak-store-document:1809866,1811575,1811702,1811709,1811823,1811835,1811931,1812739,1812750,1812753,1814407,1814499,1814579,1815450,1815466,1815940,1816436,1818301,1818303,1818903,1818906,1819421,1820199,1820661,1821130,1821477,1821487,1824962
/jackrabbit/trunk/oak-core:1345480
Modified:
jackrabbit/oak/branches/1.6/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.6/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java?rev=1825035&r1=1825034&r2=1825035&view=diff
==============================================================================
---
jackrabbit/oak/branches/1.6/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java
(original)
+++
jackrabbit/oak/branches/1.6/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java
Thu Feb 22 08:52:17 2018
@@ -843,8 +843,14 @@ public final class DocumentNodeStore
}
} else {
// branch commit
- c.applyToCache(c.getBaseRevision(), isBranch);
- return
c.getBaseRevision().update(c.getRevision().asBranchRevision());
+ try {
+ c.applyToCache(c.getBaseRevision(), isBranch);
+ return
c.getBaseRevision().update(c.getRevision().asBranchRevision());
+ } finally {
+ if (isDisableBranches()) {
+ backgroundOperationLock.readLock().unlock();
+ }
+ }
}
}
@@ -856,9 +862,15 @@ public final class DocumentNodeStore
backgroundOperationLock.readLock().unlock();
}
} else {
- Branch b = branches.getBranch(c.getBaseRevision());
- if (b != null) {
- b.removeCommit(c.getRevision().asBranchRevision());
+ try {
+ Branch b = branches.getBranch(c.getBaseRevision());
+ if (b != null) {
+ b.removeCommit(c.getRevision().asBranchRevision());
+ }
+ } finally {
+ if (isDisableBranches()) {
+ backgroundOperationLock.readLock().unlock();
+ }
}
}
}
@@ -2344,7 +2356,14 @@ public final class DocumentNodeStore
checkOpen();
Commit c = new Commit(this, newRevision(), base);
- if (!isDisableBranches()) {
+ if (isDisableBranches()) {
+ // Regular branch commits do not need to acquire the background
+ // operation lock because the head is not updated and no pending
+ // lastRev updates are done on trunk. When branches are disabled,
+ // a branch commit becomes a pseudo trunk commit and the lock
+ // must be acquired.
+ backgroundOperationLock.readLock().lock();
+ } else {
Revision rev = c.getRevision().asBranchRevision();
// remember branch commit
Branch b = getBranches().getBranch(base);
Modified:
jackrabbit/oak/branches/1.6/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DisableBranchesTest.java
URL:
http://svn.apache.org/viewvc/jackrabbit/oak/branches/1.6/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DisableBranchesTest.java?rev=1825035&r1=1825034&r2=1825035&view=diff
==============================================================================
---
jackrabbit/oak/branches/1.6/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DisableBranchesTest.java
(original)
+++
jackrabbit/oak/branches/1.6/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/document/DisableBranchesTest.java
Thu Feb 22 08:52:17 2018
@@ -31,7 +31,6 @@ import org.apache.jackrabbit.oak.spi.sta
import org.apache.jackrabbit.oak.spi.state.NodeStore;
import org.junit.After;
import org.junit.Before;
-import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
@@ -66,7 +65,6 @@ public class DisableBranchesTest {
logCustomizer.finished();
}
- @Ignore("OAK-6392")
@Test
public void backgroundWrite() throws Exception {
final int NUM_UPDATES = DocumentRootBuilder.UPDATE_LIMIT * 3 / 2;
