Author: angela
Date: Wed Dec  5 14:58:09 2018
New Revision: 1848219

URL: http://svn.apache.org/viewvc?rev=1848219&view=rev
Log:
OAK-7944 : Minor improvements to oak security code base
- fix broken javadoc links
- remove redundant @see
- use {@code} instead of <code>

Modified:
    
jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalProvider.java
    
jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundConnectionValidator.java
    
jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundLookupConnectionValidator.java
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authentication/token/TokenProviderImpl.java
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/CompiledPermissionImpl.java
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/GlobPattern.java
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/ItemNamePattern.java
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/PrefixPattern.java
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/ImpersonationImpl.java
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java
    
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserManagerImpl.java
    
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/plugins/tree/TreeContext.java
    
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/credentials/AbstractCredentials.java
    
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalImpl.java
    
jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/AccessControlActionTest.java

Modified: 
jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalProvider.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalProvider.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalProvider.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalProvider.java
 Wed Dec  5 14:58:09 2018
@@ -70,7 +70,7 @@ import org.slf4j.LoggerFactory;
 
 /**
  * Implementation of the {@code PrincipalProvider} interface that exposes
- * 'external' principals of type {@link 
org.apache.jackrabbit.oak.spi.security.principal.GroupPrincipal}. 'External'
+ * 'external' principals of type {@link 
org.apache.jackrabbit.api.security.principal.GroupPrincipal}. 'External'
  * refers to the fact that these principals are defined and managed by an
  * {@link 
org.apache.jackrabbit.oak.spi.security.authentication.external.ExternalIdentityProvider}.
  *
@@ -267,7 +267,7 @@ class ExternalGroupPrincipalProvider imp
     //------------------------------------------------------< inner classes 
>---
 
     /**
-     * Implementation of the {@link Group} interface representing external 
group
+     * Implementation of the {@link 
org.apache.jackrabbit.api.security.principal.GroupPrincipal} interface 
representing external group
      * identities that are <strong>not</strong> represented as authorizable 
group
      * in the repository's user management.
      */
@@ -340,7 +340,7 @@ class ExternalGroupPrincipalProvider imp
     }
 
     /**
-     * {@link Group} principal iterator converting the query results of
+     * Principal iterator converting the query results of
      * {@link #findPrincipals(String, int)} and {@link #findPrincipals(int)}.
      * Since each result row provides the values of the {@code PropertyState},
      * which matched the query, this iterator needs to filter the individual

Modified: 
jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundConnectionValidator.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundConnectionValidator.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundConnectionValidator.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundConnectionValidator.java
 Wed Dec  5 14:58:09 2018
@@ -25,7 +25,7 @@ import org.apache.directory.ldap.client.
 public class UnboundConnectionValidator implements LdapConnectionValidator {
 
     /**
-     * Returns true if <code>connection</code> is connected
+     * Returns true if {@code connection} is connected
      *
      * @param connection The connection to validate
      * @return True, if the connection is still valid

Modified: 
jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundLookupConnectionValidator.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundLookupConnectionValidator.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundLookupConnectionValidator.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-auth-ldap/src/main/java/org/apache/jackrabbit/oak/security/authentication/ldap/impl/UnboundLookupConnectionValidator.java
 Wed Dec  5 14:58:09 2018
@@ -35,7 +35,7 @@ public class UnboundLookupConnectionVali
     private static final Logger log = 
LoggerFactory.getLogger(UnboundLookupConnectionValidator.class);
 
     /**
-     * Returns true if <code>connection</code> is connected, authenticated, and
+     * Returns true if {@code connection} is connected, authenticated, and
      * a lookup on the rootDSE returns a non-null response.
      *
      * @param connection The connection to validate

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authentication/token/TokenProviderImpl.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authentication/token/TokenProviderImpl.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authentication/token/TokenProviderImpl.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authentication/token/TokenProviderImpl.java
 Wed Dec  5 14:58:09 2018
@@ -492,7 +492,7 @@ class TokenProviderImpl implements Token
      * Method that determines if the cleanup should run or not based on the
      * randomly generated token's first char, this decreases the chances to 
1/8.
      *
-     * @param tkn
+     * @param token The target token
      * @return true if the cleanup should run
      */
     static boolean shouldRunCleanup(@NotNull String token) {

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/CompiledPermissionImpl.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/CompiledPermissionImpl.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/CompiledPermissionImpl.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/CompiledPermissionImpl.java
 Wed Dec  5 14:58:09 2018
@@ -195,7 +195,7 @@ final class CompiledPermissionImpl imple
                         log.warn("Cannot retrieve versionable node for " + 
tree.getPath());
                         return EMPTY;
                     } else {
-                        /**
+                        /*
                          * NOTE: may return wrong results in case of 
restrictions
                          * that would match the path of the versionable node
                          * (or item in the subtree) but that item no longer 
exists

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/GlobPattern.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/GlobPattern.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/GlobPattern.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/GlobPattern.java
 Wed Dec  5 14:58:09 2018
@@ -149,25 +149,16 @@ final class GlobPattern implements Restr
     }
 
     //-------------------------------------------------------------< Object 
>---
-    /**
-     * @see Object#hashCode()
-     */
     @Override
     public int hashCode() {
         return Objects.hashCode(path, restriction);
     }
 
-    /**
-     * @see Object#toString()
-     */
     @Override
     public String toString() {
         return path + " : " + restriction;
     }
 
-    /**
-     * @see Object#equals(Object)
-     */
     @Override
     public boolean equals(Object obj) {
         if (obj == this) {

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/ItemNamePattern.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/ItemNamePattern.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/ItemNamePattern.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/ItemNamePattern.java
 Wed Dec  5 14:58:09 2018
@@ -61,25 +61,16 @@ class ItemNamePattern implements Restric
     }
 
     //-------------------------------------------------------------< Object 
>---
-    /**
-     * @see Object#hashCode()
-     */
     @Override
     public int hashCode() {
         return names.hashCode();
     }
 
-    /**
-     * @see Object#toString()
-     */
     @Override
     public String toString() {
         return names.toString();
     }
 
-    /**
-     * @see Object#equals(Object)
-     */
     @Override
     public boolean equals(Object obj) {
         if (obj == this) {

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java
 Wed Dec  5 14:58:09 2018
@@ -62,25 +62,16 @@ class NodeTypePattern implements Restric
     }
 
     //-------------------------------------------------------------< Object 
>---
-    /**
-     * @see Object#hashCode()
-     */
     @Override
     public int hashCode() {
         return nodeTypeNames.hashCode();
     }
 
-    /**
-     * @see Object#toString()
-     */
     @Override
     public String toString() {
         return nodeTypeNames.toString();
     }
 
-    /**
-     * @see Object#equals(Object)
-     */
     @Override
     public boolean equals(Object obj) {
         if (obj == this) {

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/PrefixPattern.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/PrefixPattern.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/PrefixPattern.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/PrefixPattern.java
 Wed Dec  5 14:58:09 2018
@@ -70,25 +70,16 @@ class PrefixPattern implements Restricti
     }
 
     //-------------------------------------------------------------< Object 
>---
-    /**
-     * @see Object#hashCode()
-     */
     @Override
     public int hashCode() {
         return prefixes.hashCode();
     }
 
-    /**
-     * @see Object#toString()
-     */
     @Override
     public String toString() {
         return prefixes.toString();
     }
 
-    /**
-     * @see Object#equals(Object)
-     */
     @Override
     public boolean equals(Object obj) {
         if (obj == this) {

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/ImpersonationImpl.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/ImpersonationImpl.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/ImpersonationImpl.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/ImpersonationImpl.java
 Wed Dec  5 14:58:09 2018
@@ -59,9 +59,6 @@ class ImpersonationImpl implements Imper
 
     //------------------------------------------------------< Impersonation 
>---
 
-    /**
-     * @see 
org.apache.jackrabbit.api.security.user.Impersonation#getImpersonators()
-     */
     @NotNull
     @Override
     public PrincipalIterator getImpersonators() throws RepositoryException {
@@ -83,9 +80,6 @@ class ImpersonationImpl implements Imper
         }
     }
 
-    /**
-     * @see 
org.apache.jackrabbit.api.security.user.Impersonation#grantImpersonation(Principal)
-     */
     @Override
     public boolean grantImpersonation(@NotNull Principal principal) throws 
RepositoryException {
         if (!isValidPrincipal(principal)) {
@@ -112,9 +106,6 @@ class ImpersonationImpl implements Imper
         }
     }
 
-    /**
-     * @see Impersonation#revokeImpersonation(java.security.Principal)
-     */
     @Override
     public boolean revokeImpersonation(@NotNull Principal principal) throws 
RepositoryException {
         String pName = principal.getName();
@@ -131,9 +122,6 @@ class ImpersonationImpl implements Imper
         }
     }
 
-    /**
-     * @see Impersonation#allows(javax.security.auth.Subject)
-     */
     @Override
     public boolean allows(@Nullable Subject subject) throws 
RepositoryException {
         if (subject == null) {

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipProvider.java
 Wed Dec  5 14:58:09 2018
@@ -55,7 +55,7 @@ import org.slf4j.LoggerFactory;
  * Note that the writing of the members is done in {@link MembershipWriter} so 
that the logic can be re-used by the
  * migration code.
  *
- * The current implementation uses a fixed threshold value of {@link 
MembershipWriter#DEFAULT_MEMBERSHIP_THRESHHOLD} before creating
+ * The current implementation uses a fixed threshold value of {@link 
MembershipWriter#DEFAULT_MEMBERSHIP_THRESHOLD} before creating
  * {@link #NT_REP_MEMBER_REFERENCES} sub nodes.
  *
  * Example Group with few members (irrelevant properties excluded):

Modified: 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserManagerImpl.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserManagerImpl.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserManagerImpl.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/UserManagerImpl.java
 Wed Dec  5 14:58:09 2018
@@ -231,8 +231,6 @@ public class UserManagerImpl implements
      * Always returns {@code false}. Any modifications made to this user
      * manager instance require a subsequent call to {@link 
javax.jcr.Session#save()}
      * in order to have the changes persisted.
-     *
-     * @see org.apache.jackrabbit.api.security.user.UserManager#isAutoSave()
      */
     @Override
     public boolean isAutoSave() {
@@ -242,8 +240,6 @@ public class UserManagerImpl implements
     /**
      * Changing the auto-save behavior is not supported by this implementation
      * and this method always throws {@code 
UnsupportedRepositoryOperationException}
-     *
-     * @see UserManager#autoSave(boolean)
      */
     @Override
     public void autoSave(boolean enable) throws RepositoryException {

Modified: 
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/plugins/tree/TreeContext.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/plugins/tree/TreeContext.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/plugins/tree/TreeContext.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/plugins/tree/TreeContext.java
 Wed Dec  5 14:58:09 2018
@@ -30,7 +30,7 @@ public interface TreeContext {
 
     /**
      * Reveals if the specified {@code PropertyState} is defined by the
-     * module that exposes this {@link TreeContext} instance.
+     * module that exposes this instance.
      *
      * @param parent The parent tree of the property state.
      * @param property The {@code PropertyState} to be tested.
@@ -41,7 +41,7 @@ public interface TreeContext {
 
     /**
      * Reveals if the specified {@code Tree} is the root of a subtree defined 
by
-     * the module that exposes this {@link TreeContext} instance. Note,
+     * the module that exposes this instance. Note,
      * that in contrast to {@link #definesTree(Tree)}
      * this method will return {@code false} for any tree located in the
      * subtree.
@@ -54,7 +54,7 @@ public interface TreeContext {
 
     /**
      * Reveals if the specified {@code Tree} is defined by the
-     * module that exposes this {@link TreeContext} instance.
+     * module that exposes this instance.
      *
      * @param tree The tree to be tested.
      * @return {@code true} if the specified tree is related to or defined by 
the
@@ -64,7 +64,7 @@ public interface TreeContext {
 
     /**
      * Reveals if the specified {@code TreeLocation} is defined by the
-     * module that exposes this {@link TreeContext} instance.
+     * module that exposes this instance.
      *
      * @param location The tree location to be tested.
      * @return {@code true} if the specified tree location is related to or

Modified: 
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/credentials/AbstractCredentials.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/credentials/AbstractCredentials.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/credentials/AbstractCredentials.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/credentials/AbstractCredentials.java
 Wed Dec  5 14:58:09 2018
@@ -70,13 +70,13 @@ public abstract class AbstractCredential
     }
     
     /**
-     * Returns the value of the named attribute as an <code>Object</code>, or
-     * <code>null</code> if no attribute of the given name exists.
+     * Returns the value of the named attribute as an {@code Object}, or
+     * {@code null} if no attribute of the given name exists.
      *
      * @param name
-     *            a <code>String</code> specifying the name of the attribute
-     * @return an <code>Object</code> containing the value of the attribute, or
-     *         <code>null</code> if the attribute does not exist
+     *            a {@code String} specifying the name of the attribute
+     * @return an {@code Object} containing the value of the attribute, or
+     *         {@code null} if the attribute does not exist
      */
     @Nullable
     public Object getAttribute(@NotNull String name) {
@@ -89,7 +89,7 @@ public abstract class AbstractCredential
      * Removes an attribute from this credentials instance.
      *
      * @param name
-     *            a <code>String</code> specifying the name of the attribute to
+     *            a {@code String} specifying the name of the attribute to
      *            remove
      */
     public void removeAttribute(@NotNull String name) {

Modified: 
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalImpl.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalImpl.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalImpl.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalImpl.java
 Wed Dec  5 14:58:09 2018
@@ -40,7 +40,6 @@ public class PrincipalImpl implements Ja
     //-------------------------------------------------------------< Object 
>---
     /**
      * Two principals are equal, if their names are.
-     * @see Object#equals(Object)
      */
     @Override
     public boolean equals(Object obj) {
@@ -55,16 +54,12 @@ public class PrincipalImpl implements Ja
 
     /**
      * @return the hash code of the principals name.
-     * @see Object#hashCode()
      */
     @Override
     public int hashCode() {
         return name.hashCode();
     }
 
-    /**
-     * @see Object#toString()
-     */
     @Override
     public String toString() {
         StringBuilder sb = new StringBuilder();

Modified: 
jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/AccessControlActionTest.java
URL: 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/AccessControlActionTest.java?rev=1848219&r1=1848218&r2=1848219&view=diff
==============================================================================
--- 
jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/AccessControlActionTest.java
 (original)
+++ 
jackrabbit/oak/trunk/oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/user/action/AccessControlActionTest.java
 Wed Dec  5 14:58:09 2018
@@ -41,7 +41,7 @@ import static org.mockito.Mockito.when;
 /**
  * Unit tests for {@code AccessControlAction}.
  *
- * @see {@link 
org.apache.jackrabbit.oak.security.user.action.AccessControlActionTest} for 
integration tests include complete setup.
+ * @see {@code 
org.apache.jackrabbit.oak.security.user.action.AccessControlActionTest} for 
integration tests include complete setup.
  */
 public class AccessControlActionTest implements UserConstants {
 


Reply via email to