This is an automated email from the ASF dual-hosted git repository.

reschke pushed a commit to branch 1.22
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git


The following commit(s) were added to refs/heads/1.22 by this push:
     new 6bafacd978 OAK-9527 : Typos in security related API
6bafacd978 is described below

commit 6bafacd9783cdc7bed2bc3a64e67db944aa39652
Author: angela <[email protected]>
AuthorDate: Wed Aug 11 13:58:55 2021 +0200

    OAK-9527 : Typos in security related API
---
 .../src/main/java/org/apache/jackrabbit/api/JackrabbitSession.java    | 4 ++--
 .../api/security/authentication/token/TokenCredentials.java           | 4 ++--
 .../api/security/authorization/PrincipalAccessControlList.java        | 2 +-
 .../java/org/apache/jackrabbit/api/security/user/Impersonation.java   | 1 -
 .../java/org/apache/jackrabbit/api/security/user/UserManager.java     | 2 +-
 5 files changed, 6 insertions(+), 7 deletions(-)

diff --git 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/JackrabbitSession.java
 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/JackrabbitSession.java
index 1fe1c1d4c8..e9ce7eb0f4 100644
--- 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/JackrabbitSession.java
+++ 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/JackrabbitSession.java
@@ -183,14 +183,14 @@ public interface JackrabbitSession extends Session {
      * may prevent the addition of a property called {@code C}.
      *
      * @param absPath an absolute path.
-     * @param actions one or serveral actions.
+     * @param actions one or several actions.
      * @return {@code true} if this {@code Session} has permission to
      *         perform the specified actions at the specified
      *         {@code absPath}.
      * @throws RepositoryException if an error occurs.
      * @see Session#hasPermission(String, String)
      */
-    public boolean hasPermission(@NotNull String absPath, @NotNull String... 
actions) throws RepositoryException;
+    boolean hasPermission(@NotNull String absPath, @NotNull String... actions) 
throws RepositoryException;
 
     /**
      * Returns the <code>PrincipalManager</code> for the current 
<code>Session</code>.
diff --git 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authentication/token/TokenCredentials.java
 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authentication/token/TokenCredentials.java
index 518af39bae..5a6a58200f 100644
--- 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authentication/token/TokenCredentials.java
+++ 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authentication/token/TokenCredentials.java
@@ -31,7 +31,7 @@ import java.util.HashMap;
 public final class TokenCredentials implements Credentials {
 
     private final String token;
-    private final HashMap<String, String> attributes = new HashMap<String, 
String>();
+    private final HashMap<String, String> attributes = new HashMap<>();
 
     /**
      * Create a new instance.
@@ -117,7 +117,7 @@ public final class TokenCredentials implements Credentials {
     @NotNull
     public String[] getAttributeNames() {
         synchronized (attributes) {
-            return attributes.keySet().toArray(new 
String[attributes.keySet().size()]);
+            return attributes.keySet().toArray(new String[0]);
         }
     }
 }
\ No newline at end of file
diff --git 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authorization/PrincipalAccessControlList.java
 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authorization/PrincipalAccessControlList.java
index becc0505f1..f86747efde 100644
--- 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authorization/PrincipalAccessControlList.java
+++ 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authorization/PrincipalAccessControlList.java
@@ -54,7 +54,7 @@ import java.util.Set;
  * concerned, the {@link Entry#getEffectivePath() effective path} defined with 
the individual entries will be consulted
  * in order to compute the policies that take effect at a given path.
  *
- * Irrespective on whether access by path is suppported or not the {@link 
JackrabbitAccessControlPolicy#getPath() path}
+ * Irrespective on whether access by path is supported or not the {@link 
JackrabbitAccessControlPolicy#getPath() path}
  * of the policy points to the access controlled node it is bound to and will 
be used to
  * {@link javax.jcr.security.AccessControlManager#setPolicy(String, 
AccessControlPolicy) set} and
  * {@link javax.jcr.security.AccessControlManager#removePolicy(String, 
AccessControlPolicy) remove} the policy.
diff --git 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/user/Impersonation.java
 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/user/Impersonation.java
index 06d299388c..5da064de86 100644
--- 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/user/Impersonation.java
+++ 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/user/Impersonation.java
@@ -18,7 +18,6 @@ package org.apache.jackrabbit.api.security.user;
 
 import org.apache.jackrabbit.api.security.principal.PrincipalIterator;
 import org.jetbrains.annotations.NotNull;
-import org.jetbrains.annotations.Nullable;
 
 import javax.jcr.RepositoryException;
 import javax.security.auth.Subject;
diff --git 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/user/UserManager.java
 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/user/UserManager.java
index f003e2ba9b..5b990eff13 100644
--- 
a/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/user/UserManager.java
+++ 
b/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/user/UserManager.java
@@ -36,7 +36,7 @@ import org.osgi.annotation.versioning.ProviderType;
  * Note that all <code>create</code> calls will modify the session associated
  * with the {@linkplain UserManager} (whether this is the current session or 
not
  * depends on the repository configuration). If the user manager is 
<em>not</em>
- * in "autosave" mode (see {@link UserManager#isAutoSave()}), problems like
+ * in auto-save mode (see {@link UserManager#isAutoSave()}), problems like
  * overlapping creation of intermediate nodes may only surface upon a 
subsequent
  * {@link Session#save()} operation; callers should be prepared to repeat them
  * in case this happens.

Reply via email to