This is an automated email from the ASF dual-hosted git repository.
reschke pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git
The following commit(s) were added to refs/heads/trunk by this push:
new ca7ea054c2 OAK-10524: SameNameSiblingTest: add (failing) test for
getName() semantics
ca7ea054c2 is described below
commit ca7ea054c2f9b37260ac7f36a09186846f1fa770
Author: Julian Reschke <[email protected]>
AuthorDate: Fri Oct 27 14:03:53 2023 +0100
OAK-10524: SameNameSiblingTest: add (failing) test for getName() semantics
---
.../org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git
a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java
b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java
index 786da42af6..15e9542b00 100644
---
a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java
+++
b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/SameNameSiblingTest.java
@@ -43,6 +43,7 @@ import org.apache.jackrabbit.oak.spi.commit.EmptyHook;
import org.apache.jackrabbit.oak.spi.state.NodeBuilder;
import org.apache.jackrabbit.oak.spi.state.NodeStore;
import org.junit.Before;
+import org.junit.Ignore;
import org.junit.Test;
public class SameNameSiblingTest extends AbstractRepositoryTest {
@@ -108,6 +109,18 @@ public class SameNameSiblingTest extends
AbstractRepositoryTest {
}
}
+ @Test
+ @Ignore("OAK-10523")
+ public void getSiblingNames() throws RepositoryException {
+ for (String name : SIBLINGS) {
+ Node sib = sns.getNode(name);
+ String n = sib.getName();
+ int i = sib.getIndex();
+ assertTrue("Node.getName() must return valid JCR name (index
stripped), but got: " + n, !n.contains("["));
+ assertEquals(name, n + "[" + i + "]");
+ }
+ }
+
@Test
public void modifySiblings() throws RepositoryException {
for (String name : SIBLINGS) {
