(jackrabbit-oak) 01/02: OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated

[joscorbe]

This is an automated email from the ASF dual-hosted git repository.

joscorbe pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git

commit f2f77bb06ced282e6462ed620c1a27c8bee418e9
Author: Daniel Iancu <ia...@adobe.com>
AuthorDate: Fri Mar 7 17:59:09 2025 +0200

    OAK-11570 oak-run fullGC fullGcMaxAge default value is wrongly calculated
---
 .../src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java | 4 ++--
 .../apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java 
b/oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java
index fda1d76cae..07ed36ad35 100644
--- a/oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java
+++ b/oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java
@@ -206,8 +206,8 @@ public class RevisionsCommand implements Command {
                     .withRequiredArg().ofType(Integer.class).defaultsTo(10000);
             fullGcMaxAge = parser.accepts("fullGcMaxAge", "The maximum age of 
the document in seconds " +
                             "to be considered for Full GC i.e. Version Garbage 
Collector (Full GC) logic will only consider those " +
-                            "nodes for Full GC which are not accessed recently 
(currentTime - lastModifiedTime > fullGcMaxAge)")
-                    
.withOptionalArg().ofType(Long.class).defaultsTo(TimeUnit.DAYS.toMillis(1));
+                            "nodes for Full GC which are not accessed recently 
(currentTime - lastModifiedTime > fullGcMaxAge). Default: 86400 (one day)")
+                    
.withOptionalArg().ofType(Long.class).defaultsTo(TimeUnit.DAYS.toSeconds(1));
         }
 
         public RevisionsOptions parse(String[] args) {
diff --git 
a/oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java
 
b/oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java
index 846e407162..adaef8e28c 100644
--- 
a/oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java
+++ 
b/oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/document/RevisionsCommandTest.java
@@ -201,7 +201,7 @@ public class RevisionsCommandTest {
         assertTrue(output.contains("FullGcDelayFactory is : 2.0"));
         assertTrue(output.contains("FullGcBatchSize is : 1000"));
         assertTrue(output.contains("FullGcProgressSize is : 10000"));
-        assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400"));
+        assertTrue(output.contains("FullGcMaxAgeInSecs is : 86400\n"));
         assertTrue(output.contains("FullGcMaxAgeMillis is : 86400000"));
     }