This is an automated email from the ASF dual-hosted git repository. mkataria pushed a commit to branch OAK-11694_1 in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git
commit 83c3228f210ddf20816fab2e4df21fbcbf745fdb Author: Mohit Kataria <tiho...@gmail.com> AuthorDate: Tue May 6 12:39:03 2025 +0530 OAK-11694: Exception handling updated --- .../index/elastic/query/inference/InferenceServiceUsingConfig.java | 7 +++++-- .../elastic/query/inference/InferenceServiceUsingIndexConfig.java | 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/inference/InferenceServiceUsingConfig.java b/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/inference/InferenceServiceUsingConfig.java index b5c6d9f56d..36e3100557 100644 --- a/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/inference/InferenceServiceUsingConfig.java +++ b/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/inference/InferenceServiceUsingConfig.java @@ -18,10 +18,13 @@ */ package org.apache.jackrabbit.oak.plugins.index.elastic.query.inference; +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.JsonMappingException; import com.fasterxml.jackson.databind.ObjectMapper; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import java.io.IOException; import java.net.URI; import java.net.URISyntaxException; import java.net.http.HttpClient; @@ -107,8 +110,8 @@ public class InferenceServiceUsingConfig implements InferenceService { cache.put(text, result); return result; } - } catch (Exception e) { - LOG.warn("Unable to get embeddings" + e.getMessage()); + } catch (IOException | InterruptedException e) { + throw new InferenceServiceException("Failed to get embeddings", e); } return result; } diff --git a/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/inference/InferenceServiceUsingIndexConfig.java b/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/inference/InferenceServiceUsingIndexConfig.java index 5181f23527..8704710bf0 100644 --- a/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/inference/InferenceServiceUsingIndexConfig.java +++ b/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/inference/InferenceServiceUsingIndexConfig.java @@ -21,6 +21,7 @@ package org.apache.jackrabbit.oak.plugins.index.elastic.query.inference; import com.fasterxml.jackson.databind.JsonNode; import com.fasterxml.jackson.databind.ObjectMapper; +import java.io.IOException; import java.net.URI; import java.net.URISyntaxException; import java.net.http.HttpClient; @@ -95,7 +96,7 @@ public class InferenceServiceUsingIndexConfig implements InferenceService{ cache.put(text, result); return result; - } catch (Exception e) { + } catch (IOException | InterruptedException e) { throw new InferenceServiceException("Failed to get embeddings", e); } }