(jackrabbit-oak) branch trunk updated: OAK-11982 move the calculation of the WARN limit out of the constructor (#2585)

[joerghoh]

This is an automated email from the ASF dual-hosted git repository.

joerghoh pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/jackrabbit-oak.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 06a3cdfd60 OAK-11982 move the calculation of the WARN limit out of the 
constructor (#2585)
06a3cdfd60 is described below

commit 06a3cdfd6098ba9504b636e6fd1a7ef869d2aa0b
Author: Jörg Hoh <joerg...@users.noreply.github.com>
AuthorDate: Wed Oct 15 13:43:07 2025 +0200

    OAK-11982 move the calculation of the WARN limit out of the constructor 
(#2585)
---
 .../java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java  | 11 +++++------
 .../oak/jcr/session/WarnLogStringPropertySizeTest.java        |  5 ++---
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git 
a/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java 
b/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java
index 54e8533f3d..73c7a39f10 100644
--- a/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java
+++ b/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java
@@ -128,7 +128,9 @@ public class NodeImpl<T extends NodeDelegate> extends 
ItemImpl<T> implements Jac
      */
     private static final Logger LOG = LoggerFactory.getLogger(NodeImpl.class);
 
-    private final int logWarnStringSizeThreshold;
+    private static final int LOG_WARN_STRING_SIZE_THRESHOLD = 
Integer.getInteger(
+            OakJcrConstants.WARN_LOG_STRING_SIZE_THRESHOLD_KEY,
+            OakJcrConstants.DEFAULT_WARN_LOG_STRING_SIZE_THRESHOLD_VALUE);
 
     @Nullable
     public static NodeImpl<? extends NodeDelegate> createNodeOrNull(
@@ -162,9 +164,6 @@ public class NodeImpl<T extends NodeDelegate> extends 
ItemImpl<T> implements Jac
 
     public NodeImpl(T dlg, SessionContext sessionContext) {
         super(dlg, sessionContext);
-        logWarnStringSizeThreshold = Integer.getInteger(
-                OakJcrConstants.WARN_LOG_STRING_SIZE_THRESHOLD_KEY,
-                OakJcrConstants.DEFAULT_WARN_LOG_STRING_SIZE_THRESHOLD_VALUE);
     }
 
     //---------------------------------------------------------------< Item 
>---
@@ -1425,8 +1424,8 @@ public class NodeImpl<T extends NodeDelegate> extends 
ItemImpl<T> implements Jac
     }
 
     private void logLargeStringProperties(String propertyName, String value) 
throws RepositoryException {
-        if (value.length() > logWarnStringSizeThreshold) {
-            LOG.warn("String length: {} for property: {} at Node: {} is 
greater than configured value {}", value.length(), propertyName, 
this.getPath(), logWarnStringSizeThreshold);
+        if (value.length() > LOG_WARN_STRING_SIZE_THRESHOLD) {
+            LOG.warn("String length: {} for property: {} at Node: {} is 
greater than configured value {}", value.length(), propertyName, 
this.getPath(), LOG_WARN_STRING_SIZE_THRESHOLD);
         }
     }
 
diff --git 
a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/session/WarnLogStringPropertySizeTest.java
 
b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/session/WarnLogStringPropertySizeTest.java
index e87f7cfde1..7521987153 100644
--- 
a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/session/WarnLogStringPropertySizeTest.java
+++ 
b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/session/WarnLogStringPropertySizeTest.java
@@ -47,8 +47,8 @@ public class WarnLogStringPropertySizeTest extends 
AbstractRepositoryTest {
     public TemporarySystemProperty temporarySystemProperty = new 
TemporarySystemProperty();
 
     private final static String testStringPropertyKey = 
"testStringPropertyKey";
-    private final static String testLargeStringPropertyValue = 
"abcdefghijklmnopqrstuvwxyz";
-    private final static String testSmallStringPropertyValue = "abcd";
+    private final static String testLargeStringPropertyValue = 
"a".repeat(OakJcrConstants.DEFAULT_WARN_LOG_STRING_SIZE_THRESHOLD_VALUE + 1);
+    private final static String testSmallStringPropertyValue = 
"a".repeat(OakJcrConstants.DEFAULT_WARN_LOG_STRING_SIZE_THRESHOLD_VALUE);
     private final static String nodeImplLogger = NodeImpl.class.getName();
     private final static String warnMessage = "String length: {} for property: 
{} at Node: {} is greater than configured value {}";
     private static ListAppender<ILoggingEvent> listAppender = null;
@@ -80,7 +80,6 @@ public class WarnLogStringPropertySizeTest extends 
AbstractRepositoryTest {
 
     @Test
     public void warnLogOnAddingLargeStringPropertiesWithCustomThreshold() 
throws Exception {
-        System.setProperty(OakJcrConstants.WARN_LOG_STRING_SIZE_THRESHOLD_KEY, 
"10");
         Session s = getAdminSession();
         Node test = s.getRootNode().addNode("testLarge");
         test.setProperty(testStringPropertyKey, testLargeStringPropertyValue);