angela created OAK-387:
--------------------------

             Summary: Clarify behavior/state of Root and Tree after calling 
ContentSession#close()
                 Key: OAK-387
                 URL: https://issues.apache.org/jira/browse/OAK-387
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: core
            Reporter: angela


quickly discussed this topic with jukka today in the office.
as far as i know the API contract does currently not specify what happens
to (the state of) a Root or Tree once the ContentSession has been closed.

if i am not mistaken, the current implementation would just loose 
the permissions that were granted to the original subject... but that's
rather a coincidence (and i didn't test it to verify that's really the case)

possible solutions could be:
- upon session closure the root/tree becomes invalid (invalidstate) and throws
- the root/tree are still valid but doesn't have the original permissions
  any more -> default permissions for empty-subject would apply
- ...

whatever solution we may prefer in the end, i think that API contract should
state the expected behavior (even if it was "undefined") and we should have 
tests verifying the current implementation does what we think it should do.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to