[
https://issues.apache.org/jira/browse/OAK-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487721#comment-13487721
]
angela edited comment on OAK-250 at 10/31/12 1:01 PM:
------------------------------------------------------
as you might have seen there is a TODO there and there is another TODO in the
TypeValidator you
created earlier that again provides the same functionality (and added a third
time the exact same
but buggy code) and in effect defines an "effectivenodetype". i just didn't
want to change
too much to the original logic that's why i didn't introduce an
'EffectiveNodeType' class which
IMO was much better than having the provider return Iterable<NodeType'.
feel free to clean up any remaining redundancies but please be aware that it
wasn't me
introducing the redundancy... you may not have notice before, because the code
was just
spread all over the place. svn annotate will be your friend ;-)
was (Author: anchela):
as you might have seen there is a TODO there and there is another TODO in
the TypeValidator you
created earlier that again provides the same functionality (and added a third
time the exact same
- but buggy - code) and in effect defines an "effectivenodetype". i just didn't
want to change
too much to the original logic that's why i didn't introduce an
'EffectiveNodeType' class which
IMO was much better than having the provider return Iterable<NodeType'.
> Enforce jcr constraints for 'protected' items
> ---------------------------------------------
>
> Key: OAK-250
> URL: https://issues.apache.org/jira/browse/OAK-250
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: jcr
> Reporter: angela
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
