[ 
https://issues.apache.org/jira/browse/OAK-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Parvulescu updated OAK-410:
--------------------------------

    Attachment: OAK-410-v4-tentative.patch

attaching a tentative v4.

warning: not everything compiles after applying the patch. It's just to get a 
feel of what the problems are if we try to further refactor the initializers.

Passing a {{NodeState}} around yields the following issues (as seen in the 
patch):
 - {{InitialContent}} - not the only class that need to operate changes on a 
{{Root}}: the approach was to create a MemoryNodeStore as suggested by Jukka, 
but that looks a bit convoluted for my taste. 
Nevertheless it works, feedback appreciated.

 - {{OsgiRepositoryInitializer}} overall I'm not sure keeping a reference to a 
NodeState that is stateless is the best way, but it is doable.
the problem is in the {{#addingService}} method, how do we actually add the 
content, seeing as the {{NodeState}} is stateless? and then index it?

                
> RepositoryInitializer runs before the CommitHooks are in place
> --------------------------------------------------------------
>
>                 Key: OAK-410
>                 URL: https://issues.apache.org/jira/browse/OAK-410
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Alex Parvulescu
>             Fix For: 0.6
>
>         Attachments: 
> 0001-OAK-410-RepositoryInitializer-runs-before-the-Commit.patch, 
> OAK-410.patch, OAK-410-v3.patch, OAK-410-v4-tentative.patch
>
>
> The InitialContent installs a bunch of content nodes before the CommitHooks 
> are enabled.
> This hurts the query indexes as they don't get notified about the initial 
> content and cannot index/process it.
> I'm mostly referring to the Auth stuff that relies on a combo of initial 
> content & queries.
> Luckily when using the PropertyIndex it does fallback to full repository 
> traversal, which works (albeit slowly). Unfortunately I can't say the same 
> for the lucene index).
> A bit of context here [0].
> [0] 
> https://issues.apache.org/jira/browse/OAK-403?focusedCommentId=13486763&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13486763

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to