[ 
https://issues.apache.org/jira/browse/OAK-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508717#comment-13508717
 ] 

Jukka Zitting commented on OAK-464:
-----------------------------------

Yes, we can do this also with the branch journal, though that solution requires 
an extra roundtrip of all commits between the MK and oak-core, which might get 
pretty expensive when dealing with large commits (big import, etc.) and/or 
remote MK access (many roundtrips). The journal approach also misses the 
potential for lower level optimizations I mentioned above. Adding a MK method 
with such a default implementation based on the branch journal would allow more 
advanced MK implementations to further optimize this case.

Re: "should be interpreted"; Yes, sorry about the confusing language. My 
intention with that phrasing was that ideally a MK implementation would be able 
to automatically resolve conflicts like that (i.e. SHOULD rather than MUST), 
but a simpler implementation could just throw exceptions in such cases (as long 
as it doesn't need to support fully concurrent commits). In the latter case 
such commits would simply fail without oak-core trying to do anything extra 
about the matter.
                
> RootImpl.rebase() doesn't handle move operations correctly
> ----------------------------------------------------------
>
>                 Key: OAK-464
>                 URL: https://issues.apache.org/jira/browse/OAK-464
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>            Reporter: Michael Dürig
>
> Doing {{RootImpl.rebase()}} causes moves to be changed to remove followed by 
> add. Which causes moves of large sub trees to become very expensive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to