[
https://issues.apache.org/jira/browse/OAK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527777#comment-13527777
]
Thomas Mueller commented on OAK-189:
------------------------------------
If "return null" is in fact an exception, then I would prefer throwing
"IllegalArgumentException(e)" or something like that (throw a runtime exception
with the wrapped RepositoryException).
If "return null" means something else, for example the node doesn't exist, then
this should only happen in a very specific exception, for example
ItemNotFoundException or PathNotFoundException, and not on the generic
RepositoryException.
> Swallowed exceptions
> --------------------
>
> Key: OAK-189
> URL: https://issues.apache.org/jira/browse/OAK-189
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: Thomas Mueller
> Fix For: 0.6
>
>
> Exceptions should not be silently swallowed. This is currently done in
> SessionDelegate$SessionNameMapper, methods getOakPrefix(),
> getOakPrefixFromURI(), and getJcrPrefix(). Those methods catch
> RepositoryException, don't log by default (only when using debug level), and
> don't log the exception stack trace or throw an exception.
> Catching a very wide band of exceptions (RepositoryException) and then simply
> returning null is not an acceptable solution in my view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
