[ 
https://issues.apache.org/jira/browse/OAK-355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528829#comment-13528829
 ] 

Thomas Mueller commented on OAK-355:
------------------------------------

Looking at it again, I think there is even more to refactor.
Currently, we have in oak-core:

SessionQueryEngine (interface)
SessionQueryEngineImpl (class)
QueryEngineImpl (class)

So I guess there would be a naming conflict?

Also, what I don't like, is that QueryEngineImpl has a NodeState field called 
"root", but QueryEngine.executeQuery has also a parameter of type Root named 
"root". This is confusing to me - I guess not only for me :-)

I will try to come up with an idea on how to rename/refactor things.

                
> Move QueryEngine reference from ContentSession to Root
> ------------------------------------------------------
>
>                 Key: OAK-355
>                 URL: https://issues.apache.org/jira/browse/OAK-355
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Alex Parvulescu
>            Assignee: Marcel Reutegger
>             Fix For: 0.6
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to