[
https://issues.apache.org/jira/browse/OAK-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555959#comment-13555959
]
Jukka Zitting edited comment on OAK-561 at 1/17/13 9:52 AM:
------------------------------------------------------------
The patch in OAK-562 addresses also this issue.
was (Author: jukkaz):
The patch in OAK-561 addresses also this issue.
> Remove duplicate code in *DefinitionTemplateImpl
> ------------------------------------------------
>
> Key: OAK-561
> URL: https://issues.apache.org/jira/browse/OAK-561
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: angela
>
> there is quite some code duplication in PropertyDefinitionTemplateImpl and
> NodeDefinitionTemplateImpl due to the fact that they don't share a
> common ItemDefinitionTemplate. this is currently not possible since both
> classes extend from the corresponding Abstract*DefinitionBuilder.
> IMO this should be improved and i have the impression that overall
> readability of the code would benefit from this as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
