[ 
https://issues.apache.org/jira/browse/OAK-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556272#comment-13556272
 ] 

Marcel Reutegger commented on OAK-565:
--------------------------------------

bq. because mongoSync's headRevision is incremented for branch commits as well

You probably mean 'headRevision is set', right?

bq. FetchHeadRevisionIdAction used to just read headRevId in sync collection 
but we had to change it to account for branches as you already guessed.

Wouldn't it be easier to limit usage of headRevId to trunk only? Branch commits 
always come with a branch revisionId, so we know where it belongs to.
                
> CommitCommand readExistingNodes/mergeNodes called unnecessarily
> ---------------------------------------------------------------
>
>                 Key: OAK-565
>                 URL: https://issues.apache.org/jira/browse/OAK-565
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: mongomk
>            Reporter: Mete Atamel
>            Assignee: Mete Atamel
>            Priority: Minor
>         Attachments: commitcommandoptimization.patch
>
>
> CommitCommand/CommitCommandNew calls readExistingNodes and mergeNodes all the 
> time. Instead, it should only call these methods when the base revision id is 
> less than the head revision.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to