[
https://issues.apache.org/jira/browse/OAK-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581408#comment-13581408
]
Alex Parvulescu commented on OAK-644:
-------------------------------------
sure, no problem.
just run AccessControlManagerImplTest#testSetPolicy - currently marked as
ignored.
PrivilegeDefinitionStore.getBits receives an array that has only one element -
a null value.
{noformat}
java.lang.NullPointerException
at
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)
at
org.apache.jackrabbit.oak.kernel.KernelNodeState.getChildNode(KernelNodeState.java:208)
at
org.apache.jackrabbit.oak.core.ReadOnlyTree.getChild(ReadOnlyTree.java:140)
at
org.apache.jackrabbit.oak.core.ReadOnlyTree.getChild(ReadOnlyTree.java:1)
at
org.apache.jackrabbit.oak.security.privilege.PrivilegeDefinitionStore.getBits(PrivilegeDefinitionStore.java:113)
at
org.apache.jackrabbit.oak.security.authorization.PermissionHook$Diff.createEntry(PermissionHook.java:237)
at
org.apache.jackrabbit.oak.security.authorization.PermissionHook$Diff.addEntry(PermissionHook.java:197)
at
org.apache.jackrabbit.oak.security.authorization.PermissionHook$Diff.childNodeAdded(PermissionHook.java:147)
at
org.apache.jackrabbit.oak.spi.state.AbstractNodeState.compareAgainstBaseState(AbstractNodeState.java:160)
at
org.apache.jackrabbit.oak.kernel.KernelNodeState.compareAgainstBaseState(KernelNodeState.java:287)
at
org.apache.jackrabbit.oak.security.authorization.PermissionHook$Diff.childNodeAdded(PermissionHook.java:151)
at
org.apache.jackrabbit.oak.spi.state.AbstractNodeState.compareAgainstBaseState(AbstractNodeState.java:160)
at
org.apache.jackrabbit.oak.kernel.KernelNodeState.compareAgainstBaseState(KernelNodeState.java:287)
at
org.apache.jackrabbit.oak.security.authorization.PermissionHook$Diff.childNodeChanged(PermissionHook.java:164)
at
org.apache.jackrabbit.oak.plugins.memory.ModifiedNodeState$3.childNodeChanged(ModifiedNodeState.java:300)
at
org.apache.jackrabbit.oak.spi.state.AbstractNodeState.compareAgainstBaseState(AbstractNodeState.java:153)
at
org.apache.jackrabbit.oak.kernel.KernelNodeState.compareAgainstBaseState(KernelNodeState.java:287)
at
org.apache.jackrabbit.oak.plugins.memory.ModifiedNodeState.compareAgainstBaseState(ModifiedNodeState.java:271)
at
org.apache.jackrabbit.oak.security.authorization.PermissionHook.processCommit(PermissionHook.java:75)
at
org.apache.jackrabbit.oak.spi.commit.CompositeHook.processCommit(CompositeHook.java:59)
at
org.apache.jackrabbit.oak.spi.commit.CompositeHook.processCommit(CompositeHook.java:59)
at
org.apache.jackrabbit.oak.kernel.KernelNodeStoreBranch.merge(KernelNodeStoreBranch.java:128)
at org.apache.jackrabbit.oak.core.RootImpl$2.run(RootImpl.java:256)
at org.apache.jackrabbit.oak.core.RootImpl$2.run(RootImpl.java:1)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:337)
at org.apache.jackrabbit.oak.core.RootImpl.commit(RootImpl.java:251)
at
org.apache.jackrabbit.oak.security.authorization.AccessControlManagerImplTest.testSetPolicy(AccessControlManagerImplTest.java:567)
{noformat}
> Revisit PrivilegeDefinitionStore's use of null as a child name parameter
> ------------------------------------------------------------------------
>
> Key: OAK-644
> URL: https://issues.apache.org/jira/browse/OAK-644
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.7
> Reporter: Alex Parvulescu
> Assignee: angela
> Priority: Minor
> Attachments: OAK-644.patch
>
>
> As discussed on OAK-635, I'm extracting the PrivilegeDefinitionStore
> code&patch into a dedicated issue.
> Following the discussion on the dev list, I've filed it as a bug, as nulls
> are not considered valid input parameters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
