[ 
https://issues.apache.org/jira/browse/OAK-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621021#comment-13621021
 ] 

Michael Dürig commented on OAK-744:
-----------------------------------

Revision 1464088 removes the {{baseState}} field entirely and rather 
recalculates the base node state when necessary. If this turns out to be a 
performance bottleneck, we can add a similar mechanism like the one used in 
{{MemoryNodeBuilder}} where a the base state is memoised and refreshed when 
necessary (i.e. when the node's revision doesn't match the root's revision 
anymore).

As [discussed|http://markmail.org/message/xutq7czpi6xlso67], a cleaner approach 
would be to use the base state of the associated node builders instead of 
tracking the base state for each tree again. However for this to work we need 
to first move the purge logic down below the {{NodeBuilder}} level. See also 
OAK-659.
                
> Invalid base node states in TreeImpl after commit/refresh/rebase
> ----------------------------------------------------------------
>
>                 Key: OAK-744
>                 URL: https://issues.apache.org/jira/browse/OAK-744
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>
> {{TreeImpl.baseState}} in {{TreeImpl}} is not properly updated after calling 
> {{commit}}, {{refresh}} or {{rebase}} on {{Root}}. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to