[
https://issues.apache.org/jira/browse/OAK-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640323#comment-13640323
]
Michael Dürig edited comment on OAK-781 at 4/24/13 3:11 PM:
------------------------------------------------------------
At revision 1471355 I committed a reworked version of the {{MemoryNodeBuilder}}
that addresses above points:
* {{MutableNodeState}} is now a package private top level class. Its intend is
to capture the state of mutations to existing nodes.
* {{MemoryNodeBuilder}} in contrast maintains the hierarchy information and
refers to {{MutableNodeState}} instances as necessary.
Still to be done:
* --Javadoc-- Done at revision 1471389
* There seems to be some drop in performance when going full stack. Needs
investigation.
* {{MutableNodeState#setChildNode.setChildNode()}} needs a better
implementation. See FIXME.
* --{{ModifiedNodeState}} does not yet adhere to the {{NodeState}} contract
wrt. to existence and iterability. See FIXME.-- Done at revision 1471465
was (Author: mduerig):
At revision 1471355 I committed a reworked version of the
{{MemoryNodeBuilder}} that addresses above points:
* {{MutableNodeState}} is now a package private top level class. Its intend is
to capture the state of mutations to existing nodes.
* {{MemoryNodeBuilder}} in contrast maintains the hierarchy information and
refers to {{MutableNodeState}} instances as necessary.
Still to be done:
* --Javadoc-- Done at revision 1471389
* There seems to be some drop in performance when going full stack. Needs
investigation.
* {{MutableNodeState#setChildNode.setChildNode()}} needs a better
implementation. See FIXME.
* {{ModifiedNodeState}} does not yet adhere to the {{NodeState}} contract wrt.
to existence and iterability. See FIXME.
> Clarify / fix effects of MISSING_NODE as base state of NodeBuilder
> ------------------------------------------------------------------
>
> Key: OAK-781
> URL: https://issues.apache.org/jira/browse/OAK-781
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Michael Dürig
> Attachments:
> 0001-OAK-781-Clarify-fix-effects-of-MISSING_NODE-as-base-.patch,
> memorynodebuilder-1.png, OAK-781.patch
>
>
> Having a {{MISSING_NODE}} respectively a node state that returns false for
> its {{exists}} method as a base state of a node builder results in undefined
> behaviour. We need to clarify how to handle such cases for resolving OAK-766.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
