[
https://issues.apache.org/jira/browse/OAK-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651676#comment-13651676
]
Antonio Sanso commented on OAK-774:
-----------------------------------
Hi Angela, thanks a lot for your comments!! Really appreciated.
bq. that initial part doesn't cover readability of ac content, right?
Correct I haven't still tackled those.
bq. after the calculation i would first test if there is a entry in the map for
the specified path before iterating over the keys.
Well spotted indeed.
bq. . how do you then "add" addition permission if entry1 on path /a grants
read_nodes and entry2 on path /a grants read_properties?
Same here. Well spotted. I will fix this.
bq. calculate the final status have a lot of similar code... that sounds like a
candidate for being merged...
They could theoretically be merged. The reason why I have split in the first
place is for readability reasons. I personally do not like really long methods.
But I believe is matter of taste :)
bq. maybe we need a way to add/subtract readstatus (see privilegebits for a
similar concept) in order to simplify it? what do you think?
This sounds a really great approach. I'll give it a try!
> Calculate readstatus
> --------------------
>
> Key: OAK-774
> URL: https://issues.apache.org/jira/browse/OAK-774
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: core, jcr
> Reporter: angela
> Assignee: angela
> Attachments: OAK-774-patch.txt, OAK-774-test-patch.txt,
> OAK-774-test-patch.txt
>
>
> this includes 2 major steps:
> - clarify meaning of ReadStatus.*_ALL in terms of reading access control
> content (and possibly extend the set of existing status)
> - implement calculation of read status in compiled permission impl
>
> the 2 things together will allow us to improve performance within the
> SecureNodeState for those trees where a given user has full access or
> at least full access to non-ac items.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
