[ 
https://issues.apache.org/jira/browse/OAK-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665019#comment-13665019
 ] 

Thomas Mueller commented on OAK-836:
------------------------------------

> You don't have to, that's the point of the patch

I know. Your solution works well, no question about that.

> For example the #dispose method on the logwrapper is a noop

Actually, it doesn't make much sense if the LogWrapper has a "dispose()" method 
if it doesn't do anything. I will remove it.
                
> MongoMk LogWrapper generics
> ---------------------------
>
>                 Key: OAK-836
>                 URL: https://issues.apache.org/jira/browse/OAK-836
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mongomk
>            Reporter: Alex Parvulescu
>            Priority: Minor
>         Attachments: OAK-836.patch
>
>
> I tried using the LogWrapper and I think that it could be improved by 
> exposing the wrapped mk impl as the actual class not just a _MicroKernel_
> For example this helps with wrapping the _MongoMK_ and making sure the call 
> to #dispose goes where it should (not to the noop from the LogWrapper).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to