[
https://issues.apache.org/jira/browse/OAK-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716445#comment-13716445
]
Thomas Mueller commented on OAK-318:
------------------------------------
The current implementation is a hack in my view. It isn't in line with the rest
of the query engine.
For example the excerpt value is now calculated when the method
ResultRow.getValue is called, which is too late (for example sorting by excerpt
wouldn't work). Instead, the value should be calculated when generating the
row, in the same way as all values are calculated when generating the row.
Also, the method extractExcerptProperty is brittle (throws a "String index out
of range" in some cases; anyway trying to parse things should be done in the
parser and not at that stage).
This will require some changes.
The biggest problem is that these issues blocks OAK-904.
> Excerpt support
> ---------------
>
> Key: OAK-318
> URL: https://issues.apache.org/jira/browse/OAK-318
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: core
> Reporter: Alex Parvulescu
> Assignee: Thomas Mueller
>
> Test class: ExcerptTest.
> Right now I only see parse errors:
> Caused by: java.text.ParseException: Query:
> {noformat}
> testroot/*[jcr:contains(., 'jackrabbit')]/rep:excerpt((*).); expected: <end>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
