[ 
https://issues.apache.org/jira/browse/OAK-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720821#comment-13720821
 ] 

angela commented on OAK-212:
----------------------------

just create a quick test and it seems that this is not yet fixed. the culprit 
seems to be the check for existence of the parent tree while calling 
getStatus().

the proposed patch (see attachement) seems to solve the issue with the property 
status (test on JCR API and on OAK API), but causes an observation event to 
fail: 

Failed tests:   
observation2[0](org.apache.jackrabbit.oak.jcr.observation.ObservationTest): 
Unexpected events: [EventImpl{type=2, jcrPath='/test_node/n2', 
userID='oak:unknown', identifier='/test_node/n2', info={}, date=0, 
userData=null, external=true}, EventImpl{type=8, 
jcrPath='/test_node/n2/jcr:primaryType', userID='oak:unknown', 
identifier='/test_node/n2', info={}, date=0, userData=null, external=true}, 
EventImpl{type=1, jcrPath='/test_node/n1', userID='oak:unknown', 
identifier='/test_node/n1', info={}, date=0, userData=null, external=true}, 
EventImpl{type=4, jcrPath='/test_node/n1/jcr:primaryType', 
userID='oak:unknown', identifier='/test_node/n1', info={}, date=0, 
userData=null, external=true}, EventImpl{type=2, jcrPath='/test_node/n1', 
userID='admin', identifier='/test_node/n1', info={}, date=1374847713707, 
userData=null, external=false}, EventImpl{type=8, 
jcrPath='/test_node/n1/jcr:primaryType', userID='admin', 
identifier='/test_node/n1', info={}, date=1374847713707, userData=null, 
external=false}, EventImpl{type=1, jcrPath='/test_node/n2', userID='admin', 
identifier='/test_node/n2', info={}, date=1374847713707, userData=null, 
external=false}, EventImpl{type=4, jcrPath='/test_node/n2/jcr:primaryType', 
userID='admin', identifier='/test_node/n2', info={}, date=1374847713707, 
userData=null, external=false}]

[~mduerig], i would be glad if you could take a look... 


                
> Move status of property to PropertyState
> ----------------------------------------
>
>                 Key: OAK-212
>                 URL: https://issues.apache.org/jira/browse/OAK-212
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: angela
>
> Currently the status of a property is retrieved from the parent tree object.
> With access control being enforced a property may be accessible even if the
> parent tree isn't.
> IMO the status should therefore be retrieved from the PropertyState instead
> of calling Tree#getPropertyStatus.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to