[ 
https://issues.apache.org/jira/browse/OAK-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732008#comment-13732008
 ] 

angela commented on OAK-938:
----------------------------

why does the tentative fix contain modifications to the UserManagerImpl in 
oak-core? as far as i saw it was only
changing the order of the imports, thus unrelated to this issue, isn't it? if 
that's the case, please revert it to keep the revisions and issue references 
clean.

as far as the modifications to SessionContext is concerned:
looks ok to me at first glace. indeed, i would rather avoid creating such a 
huge anonymous inner class and thus rather extract it to the security package. 
for proper separation i would avoid keeping it on the top level.

as far as the other affected areas are concerned: i would suggest that we first 
get some more confidence that
it works as expected and doesn't have any other side effects before going ahead 
with all the others. 
                
> UserManager does not honour session refresh settings
> ----------------------------------------------------
>
>                 Key: OAK-938
>                 URL: https://issues.apache.org/jira/browse/OAK-938
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Antonio Sanso
>            Assignee: Michael Dürig
>         Attachments: OAK-938-patch, OAK-938-test-patch.txt
>
>
> When UserManager#getAuthorizable is used in a multiple sessions environment 
> where a session creates an user and the other (already acquired) session 
> tries to get the authorizable null is returned (even if the other session 
> uses refresh-interval to 0)
> unit test to follow

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to