[ 
https://issues.apache.org/jira/browse/OAK-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739602#comment-13739602
 ] 

Jukka Zitting commented on OAK-960:
-----------------------------------

The way it's defined in the patch ("only for reading purposes"), the 
{{SessionOperationInterceptor}} interface would not allow the second goal 
mentioned in the summary.

Also, I'm a bit worried about adding a generic extension point to a pretty 
performance-sensitive place like this. Even a single property access in such an 
interceptor could have massive performance implications, as it would 
essentially double the cost of accessing content.

Would it be better to split this into two simpler tasks, one for extra logging 
and another for the mentioned refresh coordination? We could handle those (and 
other similar needs) separately and thus have a better idea of the implications.
                
> Provide an interceptor for SessionOperations
> --------------------------------------------
>
>                 Key: OAK-960
>                 URL: https://issues.apache.org/jira/browse/OAK-960
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: core, jcr
>    Affects Versions: 0.8
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>         Attachments: OAK-960.patch
>
>
> To support certain scenarios like
> * Logging session operation being performed
> * Coordinating refresh state among multiple session used in same thread
> It would be helpful to expose a {{SessionOperationInterceptor}} which can be 
> invoked by the {{SessionDelegate}} before and after the operation is 
> performed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to