[
https://issues.apache.org/jira/browse/OAK-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744923#comment-13744923
]
Thomas Mueller commented on OAK-828:
------------------------------------
There is quite a number of tests, that's great!
{code}
return new ArrayList<String>().iterator();
{code}
I would use "Iterators.empty();" instead :-)
The interface {{Rule}}: I guess it's there as a placeholder, to be used when
{{PropertyNameRule}} is added, right? What I would already try to do
differently is: currently {{Rule}}, is a marker interface, but could a
"matches" method be added, and the logic of {{SimpleNodeAggregator.getParents}}
be changed to call this method, instead of accessing the {{ChildNameRule}}
object directly? Usually I'm not against structs, but here maybe it's not
necessary.
There commented test "JCR-3160", why is it commented? If not implemented yet,
wouldn't it be possible to use {{@Ignore}}?
Otherwise, that's it from my side.
> Full-text support for index aggregates
> --------------------------------------
>
> Key: OAK-828
> URL: https://issues.apache.org/jira/browse/OAK-828
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: oak-lucene, query
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Attachments: aggregates.patch
>
>
> There's no support for indexing aggregates in Oak [0]
> I'd like to start slowly rolling some basic support in, so that at least
> assumptions like fulltext search on files work properly.
> [0] http://wiki.apache.org/jackrabbit/IndexingConfiguration
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
