[
https://issues.apache.org/jira/browse/OAK-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13773353#comment-13773353
]
Michael Dürig commented on OAK-1030:
------------------------------------
+1 for the patch.
bq. Would it be useful to get rid of (or at least rename) the create methods
Yes, I think so. I quickly went through the code and found two more places with
redundant exists checks: {{SessionDelegate#getNodeByIdentifier}} and
{{NodeDelegate#getParent}}.
> Simplify SessionDelegate#getItem
> --------------------------------
>
> Key: OAK-1030
> URL: https://issues.apache.org/jira/browse/OAK-1030
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: Alex Parvulescu
> Attachments: SessionDelegate.patch
>
>
> The _getItem_ call generates extra existence verification calls for both
> property and nodes, which also happen in the delegate #create calls.
> The simplification I'm proposing also has some perf gains:
> {code}
> -- before:
> # ReadDeepTreeTest min 10% 50% 90% max N
> Oak-Tar 216 224 229 237 297 261
> # ConcurrentReadDeepTreeTest min 10% 50% 90% max N
> Oak-Tar 2416 2604 2833 3916 5671 20
> -- after:
> # ReadDeepTreeTest min 10% 50% 90% max N
> Oak-Tar 195 199 204 212 280 292
> # ConcurrentReadDeepTreeTest min 10% 50% 90% max N
> Oak-Tar 1909 1997 2244 2498 2616 27
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
