[ 
https://issues.apache.org/jira/browse/OAK-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778848#comment-13778848
 ] 

Alex Parvulescu commented on OAK-1048:
--------------------------------------

just take a peek at [0] to get an idea. it is really fragile code, as soon as 
somebody touches the node type management, this will break.


[0] 
http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java?view=markup#l90

                
> Unify node type management in the query index impls
> ---------------------------------------------------
>
>                 Key: OAK-1048
>                 URL: https://issues.apache.org/jira/browse/OAK-1048
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, query
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>
> Currently the query index implementations that are node type aware access 
> this info directly from the NodeState by reading the child nodes.
> This is fragile (the node type managemet impl may change structure and break 
> the tests), and also may hide some access patterns which are node-type 
> related behind normal _getChildNode_ calls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to