[ 
https://issues.apache.org/jira/browse/OAK-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783891#comment-13783891
 ] 

Thomas Mueller commented on OAK-1063:
-------------------------------------

Thanks Jukka! My change in revision 1528442 is a bit hacky because I duplicated 
some code.

> MutableTree.enter() simplification
> ----------------------------------
>
>                 Key: OAK-1063
>                 URL: https://issues.apache.org/jira/browse/OAK-1063
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Minor
>
> Currently, the method MutableTree.enter() is called a lot and returns a 
> boolean, but the return value is rarely used. 
> To me it's not clear why the method should return a value, and what that 
> value would mean (there is no javadoc). It seems to mean "exists", but then 
> we also have a method exists(). So it seems the additional work is not needed 
> when calling enter().



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to