[
https://issues.apache.org/jira/browse/OAK-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jukka Zitting resolved OAK-1063.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.10
See revisions 1528472 and 1528485 for the followup.
To make things clearer I ended up renaming the {{enter()}} and
{{checkExists()}} methods to {{beforeRead()}} and {{beforeWrite()}}, as that'll
match their use cases more obvious. There's now also some extra javadocs to
explain why and how these methods are used.
> MutableTree.enter() simplification
> ----------------------------------
>
> Key: OAK-1063
> URL: https://issues.apache.org/jira/browse/OAK-1063
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Priority: Minor
> Fix For: 0.10
>
>
> Currently, the method MutableTree.enter() is called a lot and returns a
> boolean, but the return value is rarely used.
> To me it's not clear why the method should return a value, and what that
> value would mean (there is no javadoc). It seems to mean "exists", but then
> we also have a method exists(). So it seems the additional work is not needed
> when calling enter().
--
This message was sent by Atlassian JIRA
(v6.1#6144)
