[ 
https://issues.apache.org/jira/browse/OAK-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804142#comment-13804142
 ] 

Michael Dürig commented on OAK-1114:
------------------------------------

Mostly fixed at http://svn.apache.org/r1535368.

Now the move succeeds if both, the source builder and the new parent builder 
exist, there is no child with the given name at the new parent builder and the 
new parent builder is not in the subtree of the source builder. After a 
successful move, {{exists()}} of the source builder returns {{false}}, 
otherwise it returns {{true}}.

A remaining issue is the {{MemoryNodeBuilder}} not being able to detect moves 
into a subtree of the source tree. This causes 
{{NodeStoreTest#moveToDescendant}} to fail for the SegmentMK. I excluded this 
test for the respective fixture for the time being. 

> Clarify NodeBuilder.moveTo() contract
> -------------------------------------
>
>                 Key: OAK-1114
>                 URL: https://issues.apache.org/jira/browse/OAK-1114
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>
> {{NodeBuilder.moveTo()}} currently behaves differently depending on the 
> implementation. We should rectify that, clarify the contract and add 
> respective unit tests. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to