[ https://issues.apache.org/jira/browse/OAK-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13814038#comment-13814038 ]
Jukka Zitting commented on OAK-1147: ------------------------------------ ... perhaps the check should be renamed to {{canListAllProperties()}} to better match the use case. > SecureNodeBuilder/SecureNodeState: Consider using > 'TreePermission#canReadProperties' > ------------------------------------------------------------------------------------ > > Key: OAK-1147 > URL: https://issues.apache.org/jira/browse/OAK-1147 > Project: Jackrabbit Oak > Issue Type: Improvement > Reporter: angela > Assignee: angela > Attachments: OAK-1147.patch > > > the methods #getProperties and #getPropertyCount have a shortcut for those > cases where all properties are accessible. > however, the current implemention requires SecurityContext#canReadAll to > return true in order to enable the shortcut. without knowing the very details > of the SecureNodeState/Builder i would have expected that > #canReadAllProperties would be sufficient. > [~jukkaz], do you remember what was the reason for using #canReadAll here? i > changed it for test purpose and didn't see any difference... but that may > also imply that we don't have enough or specific tests for this. -- This message was sent by Atlassian JIRA (v6.1#6144)