[ 
https://issues.apache.org/jira/browse/OAK-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820510#comment-13820510
 ] 

Jukka Zitting commented on OAK-1168:
------------------------------------

Continuing from the previous discussions, I think we should decouple the task 
of namespace mapping from that of name/path validation. Otherwise we incur the 
performance overhead of validation in many cases where the simpler mapping 
would suffice, which is troublesome as the cost of validation has a notable 
performance impact on content access. For example:

{noformat}
# GetNodeWithAdmin           C     min     10%     50%     90%     max       N
Oak-Tar                      1      15      15      16      17      51    3665
Oak-Tar (without r1538131)   1      20      20      21      21      82    2885
{noformat}

Thus instead of focusing on the {{null}} return value of {{getOakPath}} here, 
I'd consider relaxing the mapper contract and looking at alternative ways of 
fulfilling the higher level API contracts/expectations that are affected by 
this.

> Invalid JCR paths not caught
> ----------------------------
>
>                 Key: OAK-1168
>                 URL: https://issues.apache.org/jira/browse/OAK-1168
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, jcr
>            Reporter: Michael Dürig
>
> {{NamePathMapper.getOakPath}} should return {{null}} when called with an 
> invalid JCR path like {{foo:bar]baz}}, but it doesn't. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to