[ 
https://issues.apache.org/jira/browse/OAK-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829252#comment-13829252
 ] 

Jukka Zitting commented on OAK-1179:
------------------------------------

bq. semantics between isEmpty() and isRoot()

The {{Path}} class as drafted only handles relative paths, so it doesn't have 
the concept of {{isRoot()}}. Instead, code that wants to check for the root 
path can use {{isEmpty()}} if they already know that the path is to be 
interpreted relative to the root.

> Use dedicated Path class for handling paths in Oak
> --------------------------------------------------
>
>                 Key: OAK-1179
>                 URL: https://issues.apache.org/jira/browse/OAK-1179
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, jcr
>            Reporter: Michael Dürig
>             Fix For: 0.14
>
>         Attachments: 
> 0001-OAK-1179-Use-dedicated-Path-class-for-handling-paths.patch
>
>
> As discussed (for example [here | 
> http://markmail.org/message/abdmqgultkpfwb3x] several times before using 
> naked strings for paths is troublesome. OAK-1168 and OAK-1174 are only the 
> latest of a long history of issues we suffered because of this. 
> While wrapping the path and related entities into dedicated classes will add 
> some overhead at first. It will OTOH clearly communicate the intend of what 
> otherwise are just naked strings. In addition it will introduce a clear 
> boundary for optimisations while in the string case these blur with the 
> client code.
> I thus propose to introduce a dedicated class for paths in Oak. Such a class 
> could serve as a container for the string, which is the lazily acted upon as 
> required. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to