[
https://issues.apache.org/jira/browse/OAK-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jukka Zitting resolved OAK-928.
-------------------------------
Resolution: Fixed
Finally in revision 1545833 I enabled the
{{testAddNodeCollidingWithInvisibleNode}} test case after adjusting it's
expectations to match those of {{testShadowInvisibleProperty}} as discussed
above.
This should take care of everything for this issue, so resolving as Fixed.
I'll file a followup issue for the {{testShadowInvisibleProperty2}} case, as
the issue is about write access more than read.
> Read access is enforced on NEW items
> ------------------------------------
>
> Key: OAK-928
> URL: https://issues.apache.org/jira/browse/OAK-928
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: angela
> Assignee: Jukka Zitting
> Fix For: 0.13
>
>
> as explained in OAK-923 we may currently run into the situation where a new
> Tree is being added because it does not exist but the resulting child does
> not exist due to restricted access. the same is true for new properties.
> IMHO this breaks backwards compatibility with jackrabbit core.
> i would therefore suggest to
> - extend MutableTree#exists by checking for the tree being new
> line 390:
> {noformat}
> - return nodeBuilder.exists();
> + return nodeBuilder.isNew() || nodeBuilder.exists();
> {noformat}
> - similar behavior for #hasProperty #getProperty, #getProperties and
> #getPropertyCount (no patch yet).
> however, i would like to get a broader consensus on this kind of
> modifications as this
> might have side effects in other places.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
