[ 
https://issues.apache.org/jira/browse/OAK-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833615#comment-13833615
 ] 

Michael Dürig edited comment on OAK-1232 at 11/27/13 10:12 AM:
---------------------------------------------------------------

At http://svn.apache.org/r1545978 I implemented the property status calculation 
in {{AbstractTree}} using the new methods from {{NodeBuilder}}. 

However as the attached patch shows using this new implementation causes 
{{org.apache.jackrabbit.oak.jcr.RepositoryTest#setStringProperty}} to fail with 
the MongoNS fixture. 

For some reason in this fixture a modified property is not seen as such but as 
a new property. 


was (Author: mduerig):
At http://svn.apache.org/r1545978 I implemented the property status calculation 
in {{AbstractTree}} using the new methods from {{NodeBuilder}}. 

However as the attached patch shows using this new implementation causes 
{{org.apache.jackrabbit.oak.jcr.RepositoryTest#setStringProperty}} to fail with 
the MongoNS fixture. 

> Improve implementation of Tree.get(Property)Status 
> ---------------------------------------------------
>
>                 Key: OAK-1232
>                 URL: https://issues.apache.org/jira/browse/OAK-1232
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>            Priority: Minor
>         Attachments: OAK-1232.patch
>
>
> OAK-928 introduced methods for determining the status of a property from a 
> {{NodeBuilder}}. The implementations of {{Tree.getPropertyStatus}} should 
> change using these new methods instead of duplicating the logic. 
> Furthermore the since the {{get(Propert)Status}} methods pre-dates the 
> introduction of the {{exists}} method, we should also clarify the effect of 
> calling such methods on a non existing tree.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to