[
https://issues.apache.org/jira/browse/OAK-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845240#comment-13845240
]
angela edited comment on OAK-884 at 12/11/13 10:09 AM:
-------------------------------------------------------
oh. thanks... but it still fails on my machine.
while trying to find the source of the problem i had another look at the code
and to be honest i am a bit disappointed about the overall quality of the patch:
- the tear down will throw NPE if something went wrong during the setup
- the code is over complicated and could be heavily simplified if you would
keep just the list read and write sessions irrespective of their origin.
- the test modifies the root node without reverting the changes, which may
later on cause
troubles with other test cases.
- typos in method names
- setting up the user/groups looks quite odd and instead of just doing it in
one step you create the user first and the retrieve it by principal (which
might be expensive) and add it to the group... you already had the user at
hand, why retrieving it again?
- ...
was (Author: anchela):
oh. thanks... but it still fails on my machine.
while trying to find the source of the problem i had another look at the code
and to be honest i am a bit disappointed about the overall quality of the patch:
- the tear down will throw NPE if something went wrong during the setup
- the code is over complicated and could be heavily simplified if you would
keep just the list read and write sessions irrespective of their origin.
- the test modifies the root node without reverting the changes, which may
later on cause troubles with other test cases.
- typos in method names
- ...
> Add simple randomized test
> --------------------------
>
> Key: OAK-884
> URL: https://issues.apache.org/jira/browse/OAK-884
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: run
> Reporter: Antonio Sanso
> Fix For: 0.14
>
> Attachments: OAK-884-patch.txt, OAK-884-patch.txt, OAK-884-patch.txt
>
>
> Taking as example org.apache.jackrabbit.oak.plugins.mongomk.RandomizedTest it
> would be nice to have some randomized test also for the ACL evaluation.
> The logic for the upcoming test patch is to add/remove randomly read
> permission entry and traverse the tree evaluation the read permission.
> The result is compared with a Jackrabbit (that is considered as a functional
> gold implementation) outcome and it is expected to match.
> Should not match then we have a problem...
> Patch to follow
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
