[
https://issues.apache.org/jira/browse/OAK-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847615#comment-13847615
]
Michael Dürig commented on OAK-1284:
------------------------------------
Thanks for spotting this. The proposed solution seems good enough for the time
being and should be easy to implement. I'll have a look as soon as I'm through
with my 0.14 issues.
> Root.commit(String, CommitHook) : CommitHook is not part of oak-api
> -------------------------------------------------------------------
>
> Key: OAK-1284
> URL: https://issues.apache.org/jira/browse/OAK-1284
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: angela
> Assignee: Michael Dürig
> Fix For: 0.15
>
>
> [~fmeschbe] had a look at the oak api and spotted the following problem:
> Root#commit(String, CommitHook)
> But the CommitHook interface is not part of the OAK API. we quickly searched
> for usages and found that this is only used for the Item#save case in oak-jcr
> to assert that the set of modifications is contained with the subtree defined
> by the specified target item.
> IMO we should get rid of the flavour of Root#commit again and solve the
> Item-save issue differently. For example we could change it to
> Root#commit(String, String absPath) where the absPath would be the path of
> the target item...
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
