[ 
https://issues.apache.org/jira/browse/OAK-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angela resolved OAK-1181.
-------------------------

    Resolution: Fixed

ok... i made 2 minor modifications to the node type definition:
a) naming convention
b) extending from oak:Unstructured

> Review node type definition for oak:queryIndexDefinition
> --------------------------------------------------------
>
>                 Key: OAK-1181
>                 URL: https://issues.apache.org/jira/browse/OAK-1181
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core
>            Reporter: angela
>            Assignee: angela
>             Fix For: 0.15
>
>
> current definition:
> {noformat}
> [oak:queryIndexDefinition] > nt:unstructured
>   - type (STRING) mandatory
>   - async (STRING)
>   - reindex (BOOLEAN) mandatory IGNORE
> {noformat}
> things to review:
> - name not following naming convention
> - extending from nt:unstructured
> - OPV flags (behavior upon versioning of the parent node)
> - incomplete list of properties compared to those mentioned in query.md
> - 'async' property is string with a predefined value 'async': why not boolean?
> - index content stored underneath the definition has not dedicated node type.
> things to consider:
> - is it expected that an index definition has custom properties?
> - is it expected that such custom properties have other property types that 
> STRING/NAME/BOOLEAN? e.g. a binary?
> - is it expected that an index definition has other child nodes that the 
> index content itself?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to