[ 
https://issues.apache.org/jira/browse/OAK-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876848#comment-13876848
 ] 

Jukka Zitting commented on OAK-1292:
------------------------------------

+1

For a few extra cleanups, see 
https://github.com/jukka/jackrabbit-oak/compare/apache:trunk...jukka:OAK-1292. 
Commit 
[778d94f|https://github.com/jukka/jackrabbit-oak/commit/778d94f93c50548d86c7f358eb73427644e9bac4.patch]
 turns {{IndexUpdateCallback}} to an interface, 
[434a58f|https://github.com/jukka/jackrabbit-oak/commit/434a58f3e9899d63cc02dbaf67b8a8164e380556.patch]
 uses a sentinel object to avoid extra null checks, and 
[768beb1|https://github.com/jukka/jackrabbit-oak/commit/768beb15730aeddd94e9596e77a4e8e448c1f1cb.patch]
 simplifies the two-level if statement and AtomicBoolean use in 
{{AsyncIndexUpdate.run()}}.

> Avoid async indexer commits when there are no changes to index
> --------------------------------------------------------------
>
>                 Key: OAK-1292
>                 URL: https://issues.apache.org/jira/browse/OAK-1292
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>            Assignee: Alex Parvulescu
>             Fix For: 0.15
>
>         Attachments: callback-v2.patch, callback.patch
>
>
> Currently, since OAK-980 (and OAK-1246), the asynchronous indexer makes two 
> commits per invocation regardless of whether there are any changes to the 
> indexed content. This can be a bit confusing and in some cases even 
> troublesome especially in a mostly read-only deployments where the frequent 
> extra commits just add unnecessary noise.
> It would be better if the async indexer only made commits when there actually 
> are content changes to be indexed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to