[
https://issues.apache.org/jira/browse/OAK-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878930#comment-13878930
]
Jukka Zitting edited comment on OAK-1285 at 1/22/14 6:12 PM:
-------------------------------------------------------------
Yep, that approach works. Committed in revision 1560446.
I actually ended up replacing the {{hasSessionLocalMappings()}} method with
{{getSessionLocalMappings()}} as the former can be implemented in terms of the
latter.
was (Author: jukkaz):
Yep, that approach works. Committed in revision 1560446.
I actually ended up replacing the {{hasSessionLocalMappings()}} method with
{{getSessionLocalMappings()} as the former can be implemented in terms of the
latter.
> QueryEngine#executeQuery takes NamePathMapper which is not part of oak-api
> --------------------------------------------------------------------------
>
> Key: OAK-1285
> URL: https://issues.apache.org/jira/browse/OAK-1285
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: angela
> Assignee: Jukka Zitting
> Fix For: 0.16
>
> Attachments:
> 0001-OAK-1285-QueryEngine-executeQuery-takes-NamePathMapp.patch,
> 0002-OAK-1285-QueryEngine-executeQuery-takes-NamePathMapp.patch
>
>
> [~fmeschbe] spotted the following inconsistency in the oak api:
> o.a.j.o.api.QueryEngine#executeQuery(String statement, String language,
> long limit, long offset, Map<String, ? extends PropertyValue>
> bindings,
> NamePathMapper namePathMapper) throws ParseException;
> takes a NamePathMapper which is not part of the oak api but only defined in
> the plugins.
> to resolve that inconsistency we may consider moving the NamePathMapper to a
> new o.a.j.oak.api.namepath package and keep the implementations in the
> plugins.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
