[
https://issues.apache.org/jira/browse/OAK-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882891#comment-13882891
]
Thomas Mueller commented on OAK-1157:
-------------------------------------
Hi,
Thanks for the updated patch! I could now merge it. There are still a few
problems:
* There are still some "non-Javadoc" comments. Could you remove them? For
example in MongoCloudBlobMicroKernelFixture.
* It looks like some of the tests create many directories
"repository/datastore" in the directory "oak-core", without cleaning them up.
Could you ensure those are created in the target directory, and that they are
cleaned up before and after running the test?
* License headers are missing (for example in CloudStoreUtils).
* Javadocs are missing (for example CloudStoreUtils).
* There are some tabs, could you replace them with spaces please? (for example
DataStoreConfiguration)
* Could you change the code style to "} else {" (all on the same line)? For
example in OakRepositoryFixture. The same for "try" / "catch" / "finally" (for
example in DataStoreWrapperBackend.java).
* Could you change the code style from "if(" to "if ("? For example in
DataStoreConfiguration.
* Could you change to ensure {} is used for every "if", "else", "while" block?
For example in DataStoreConfiguration.
* DataStoreConfiguration.loadFromContextOrMap has a lot of unnecessary code
repetition. Instead of an "if" / "else" block for every config option, could
you copy all options from cfgMap to a config, and then overwrite with all
options in context?
* DataStoreType (enum): I think what we want is the ability to configure the
data store, and not a fixed list of data stores. But I see the problem is
configuration. Could we use reflection to set the configuration options of the
target data store?
* The test
org.apache.jackrabbit.oak.plugins.mongomk.blob.cloud.MongoCloudBlobStoreTest
fails with the error message "Empty key" (I think an encryption key). Could you
add "@Ignore("OAK-1157")" in front of the class declaration or try to fix this
problem?
* I'm not sure about the added dependencies. What is the PostgreSQL JDBC driver
used for (oak-run)?
* The class MongoDataStoreBlobStoreTest can now extend the oak-core
AbstractBlobStoreTest. To avoid code duplication, could you change it?
* Some "Override" annotations are missing, for example in
MongoMKDataStoreReadTest.setUpConnection.
> DS implementation for S3-based DSs
> ----------------------------------
>
> Key: OAK-1157
> URL: https://issues.apache.org/jira/browse/OAK-1157
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Reporter: Michael Marth
> Assignee: Thomas Mueller
> Fix For: 0.16
>
> Attachments: OAK-1157-NEW.patch
>
>
> Related to OAK-805
> I think we need a DS implementation for the lately introduced S3 DS in
> Jackrabbit 2, so that users of that DS can easily migrate to Oak
> I think it would anyway be a very useful DS implementation to have, also for
> Oak
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
