[ 
https://issues.apache.org/jira/browse/OAK-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889698#comment-13889698
 ] 

Jukka Zitting commented on OAK-1381:
------------------------------------

{{o.a.j.o.util.ChildOrderDiff}}? {{NodeTypeConstants}} would be a bit cleaner 
alternative as orderability is related to node types, but I'm not sure whether 
it makes sense to add a generic node type dependency to the pieces of code that 
only care about ordering. Perhaps an {{OakConstants}} class in {{o.a.j.o.util}} 
would work best.

> Avoid dependency to AbstractTree outside of oak.core package
> ------------------------------------------------------------
>
>                 Key: OAK-1381
>                 URL: https://issues.apache.org/jira/browse/OAK-1381
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>         Attachments: OAK-1381.patch
>
>
> there are quite some dependencies to AbstractTree outside of oak.core 
> package. all of them just referring to the OAK_CHILD_ORDER constant.
> in order to clean this up i would suggest to move the constant to the Tree 
> interface.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to