[ 
https://issues.apache.org/jira/browse/OAK-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937578#comment-13937578
 ] 

Alex Parvulescu commented on OAK-1545:
--------------------------------------

If I remember correctly, before this refactoring we did not use to cache bulk 
segments, so if I read the code correctly (assuming the _segments_ variable 
represents a cache), I'm just going to skip adding the bulk segments to this 
cache. This is consistent with previous behavior and also is saves us from 
overloading the cache with big bulk segments which would only flush everything 
else.

> NPE in SegmentTracker
> ---------------------
>
>                 Key: OAK-1545
>                 URL: https://issues.apache.org/jira/browse/OAK-1545
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, segmentmk
>            Reporter: Alex Parvulescu
>
> There is a NPE happening on the SegmentTracker, on what appears to be the 
> cache flush of bulk segments.
> {code}
> java.lang.NullPointerException: null
>       at 
> org.apache.jackrabbit.oak.plugins.segment.Segment.getSegmentId(Segment.java:162)
>       at 
> org.apache.jackrabbit.oak.plugins.segment.SegmentTracker.getSegment(SegmentTracker.java:103)
>       at 
> org.apache.jackrabbit.oak.plugins.segment.SegmentId.getSegment(SegmentId.java:81)
>       at 
> org.apache.jackrabbit.oak.plugins.segment.Record.getSegment(Record.java:68)
>       at 
> org.apache.jackrabbit.oak.plugins.segment.BlockRecord.read(BlockRecord.java:52)
>       at 
> org.apache.jackrabbit.oak.plugins.segment.SegmentStream.read(SegmentStream.java:156)
>       at 
> org.apache.jackrabbit.oak.plugins.segment.SegmentStream.read(SegmentStream.java:125)
>       at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1792)
>       at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1769)
>       at org.apache.commons.io.IOUtils.copy(IOUtils.java:1744)
>       at 
> org.apache.jackrabbit.vault.packaging.impl.JcrPackageImpl.getPackage(JcrPackageImpl.java:346)
>       at 
> com.day.jcr.vault.packaging.impl.JrVltJcrPackageAdapter.getPackage(JrVltJcrPackageAdapter.java:86)
>       at 
> com.adobe.granite.installer.factory.packages.impl.PackageTransformer$InstallPackageTask.execute(PackageTransformer.java:278)
>       at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:733)
>       at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:247)
>       at java.lang.Thread.run(Thread.java:744)
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to