[ 
https://issues.apache.org/jira/browse/OAK-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940301#comment-13940301
 ] 

Thomas Mueller commented on OAK-1510:
-------------------------------------

The second patch OAK-1510-add-on.patch also broke a test case, 
MongoDataStoreBlobStoreTest.delete(). The reason is the change in 
DataStoreBlobStore.deleteChunks. I have fixed this now to:

{noformat}
    public boolean deleteChunks(List<String> chunkIds, long 
maxLastModifiedTime) throws Exception {
        if (delegate instanceof MultiDataStoreAware) {
            for (String chunkId : chunkIds) {
                DataIdentifier identifier = new DataIdentifier(chunkId);
                DataRecord dataRecord = delegate.getRecord(identifier);
                boolean success = (maxLastModifiedTime <= 0)
                        || dataRecord.getLastModified() <= maxLastModifiedTime;
                if (!success) {
                    return false;
                }
                ((MultiDataStoreAware) delegate).deleteRecord(identifier);
            }
        }
        return true;
{noformat}

> MongoDB / DocumentNodeStore DataStore GC performance
> ----------------------------------------------------
>
>                 Key: OAK-1510
>                 URL: https://issues.apache.org/jira/browse/OAK-1510
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>             Fix For: 0.19
>
>         Attachments: OAK-1510-add-on.patch, OAK-1510.patch
>
>
> We currently don't know what is the performance of the DSGC, and we might 
> need to improve performance of this task.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to