[ 
https://issues.apache.org/jira/browse/OAK-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949837#comment-13949837
 ] 

Jukka Zitting commented on OAK-1624:
------------------------------------

bq. But IMO all 'reading' methods should also throw a IllegalNameException 
(e.g. session.nodeExists("/content "))

Strictly speaking the name is legal according to the spec. The repository 
implementation would just refuses to store content with such names (as the spec 
allows), which is why a {{PathNotFoundException}} would IMHO be more 
appropriate here. More specifically, JCR 2.0 section 3.2.4 says: "A writable 
repository may enforce any implementation-specific constraint by causing an 
exception to be thrown on an invalid JCR write method call."

> Item names with trailing spaces should not be allowed
> -----------------------------------------------------
>
>                 Key: OAK-1624
>                 URL: https://issues.apache.org/jira/browse/OAK-1624
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, jcr
>            Reporter: Tobias Bocanegra
>            Priority: Blocker
>             Fix For: 0.20
>
>         Attachments: OAK-1624.patch
>
>
> the following should fail:
> {code}
>         Node hello = session.getRootNode().addNode("hello");
>         session.save();
>         Node illegal = hello.addNode("test "); <-- here
>         session.save();
>         assertEquals("/hello/test ", illegal.getPath()); <-- and here
>         Node other = session.getNode("/hello/test "); <-- and here
>         assertTrue(other.isSame(illegal));
>         assertTrue(session.nodeExists("/hello/test ")); <-- and here
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to