[
https://issues.apache.org/jira/browse/OAK-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Mehrotra resolved OAK-1655.
----------------------------------
Resolution: Fixed
bq. The GarbageCollectableBlobStore.deleteChunks also has a maxLastModifiedTime
parameter. If deleteChunks is implemented correctly (and called correctly),
then new binaries should not be deleted. So I don't think this TODO will cause
trouble for garbage collection.
Missed that part. We should be safe then.
Fixed in http://svn.apache.org/r1583594
> DataStoreBlobStore does not take into maxLastModifiedTime when fetching all
> chunks
> ----------------------------------------------------------------------------------
>
> Key: OAK-1655
> URL: https://issues.apache.org/jira/browse/OAK-1655
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 0.20
>
>
> Currently the {{DataStoreBlobStore}} has a pending TODO
> {code}
> @Override
> public Iterator<String> getAllChunkIds(long maxLastModifiedTime) throws
> Exception {
> //TODO Ignores the maxLastModifiedTime currently.
> return Iterators.transform(delegate.getAllIdentifiers(), new
> Function<DataIdentifier, String>() {
> @Nullable
> @Override
> public String apply(@Nullable DataIdentifier input) {
> return input.toString();
> }
> });
> }
> {code}
> Due to this it currently returns all blobId. This would issue when new binary
> gets created while a blob gc is running as such binaries might be considered
> orphan and deleted
--
This message was sent by Atlassian JIRA
(v6.2#6252)
